From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Mauro Carvalho Chehab <m.chehab@samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA
Date: Fri, 06 Sep 2013 17:20:18 +0200 [thread overview]
Message-ID: <2886273.7m0Ub6qIMh@avalon> (raw)
In-Reply-To: <1378471436-7045-1-git-send-email-geert@linux-m68k.org>
Hi Geert,
On Friday 06 September 2013 14:43:56 Geert Uytterhoeven wrote:
> If NO_DMA=y:
>
> warning: (... && VIDEO_RENESAS_VSP1 && ...) selects VIDEOBUF2_DMA_CONTIG
> which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA)
>
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’:
> drivers/media/v4l2-core/videobuf2-dma-contig.c:202: error: implicit
> declaration of function ‘dma_mmap_coherent’
> drivers/media/v4l2-core/videobuf2-dma-contig.c: In function
> ‘vb2_dc_get_base_sgt’: drivers/media/v4l2-core/videobuf2-dma-contig.c:385:
> error: implicit declaration of function ‘dma_get_sgtable’ make[7]: ***
> [drivers/media/v4l2-core/videobuf2-dma-contig.o] Error 1
>
> VIDEO_RENESAS_VSP1 (which doesn't have a platform dependency) selects
> VIDEOBUF2_DMA_CONTIG, but the latter depends on HAS_DMA.
>
> Make VIDEO_RENESAS_VSP1 depend on HAS_DMA to fix this.
Is there a chance we could fix the Kconfig infrastructure instead ? It warns
about the unmet dependency, shouldn't it disallow selecting the driver in the
first place ? I have a vague feeling that this topic has been discussed before
though.
If that's not possible,
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 8068d7b..fbc0611 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -212,7 +212,7 @@ config VIDEO_SH_VEU
>
> config VIDEO_RENESAS_VSP1
> tristate "Renesas VSP1 Video Processing Engine"
> - depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API
> + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> select VIDEOBUF2_DMA_CONTIG
> ---help---
> This is a V4L2 driver for the Renesas VSP1 video processing engine.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-09-06 15:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-06 12:43 [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA Geert Uytterhoeven
2013-09-06 15:20 ` Laurent Pinchart [this message]
2013-09-06 17:07 ` Geert Uytterhoeven
2013-09-16 16:14 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2886273.7m0Ub6qIMh@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).