From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:54755 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753853Ab3IFPUP convert rfc822-to-8bit (ORCPT ); Fri, 6 Sep 2013 11:20:15 -0400 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Laurent Pinchart , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [media] media/v4l2: VIDEO_RENESAS_VSP1 should depend on HAS_DMA Date: Fri, 06 Sep 2013 17:20:18 +0200 Message-ID: <2886273.7m0Ub6qIMh@avalon> In-Reply-To: <1378471436-7045-1-git-send-email-geert@linux-m68k.org> References: <1378471436-7045-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="utf-8" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Geert, On Friday 06 September 2013 14:43:56 Geert Uytterhoeven wrote: > If NO_DMA=y: > > warning: (... && VIDEO_RENESAS_VSP1 && ...) selects VIDEOBUF2_DMA_CONTIG > which has unmet direct dependencies (MEDIA_SUPPORT && HAS_DMA) > > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function ‘vb2_dc_mmap’: > drivers/media/v4l2-core/videobuf2-dma-contig.c:202: error: implicit > declaration of function ‘dma_mmap_coherent’ > drivers/media/v4l2-core/videobuf2-dma-contig.c: In function > ‘vb2_dc_get_base_sgt’: drivers/media/v4l2-core/videobuf2-dma-contig.c:385: > error: implicit declaration of function ‘dma_get_sgtable’ make[7]: *** > [drivers/media/v4l2-core/videobuf2-dma-contig.o] Error 1 > > VIDEO_RENESAS_VSP1 (which doesn't have a platform dependency) selects > VIDEOBUF2_DMA_CONTIG, but the latter depends on HAS_DMA. > > Make VIDEO_RENESAS_VSP1 depend on HAS_DMA to fix this. Is there a chance we could fix the Kconfig infrastructure instead ? It warns about the unmet dependency, shouldn't it disallow selecting the driver in the first place ? I have a vague feeling that this topic has been discussed before though. If that's not possible, > Signed-off-by: Geert Uytterhoeven Acked-by: Laurent Pinchart > --- > drivers/media/platform/Kconfig | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig > index 8068d7b..fbc0611 100644 > --- a/drivers/media/platform/Kconfig > +++ b/drivers/media/platform/Kconfig > @@ -212,7 +212,7 @@ config VIDEO_SH_VEU > > config VIDEO_RENESAS_VSP1 > tristate "Renesas VSP1 Video Processing Engine" > - depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API > + depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA > select VIDEOBUF2_DMA_CONTIG > ---help--- > This is a V4L2 driver for the Renesas VSP1 video processing engine. -- Regards, Laurent Pinchart