[GIT PULL for v4.1] smiapp DT u64 property workaround removal

[GIT PULL for v4.1] smiapp DT u64 property workaround removal

[Sakari Ailus]

Hi Mauro,

This pull request reverts the smiapp driver's u64 array DT property read
workaround, and uses of_property_read_u64_array() (second patch) which is
the correct API function for reading u64 arrays from DT.

Please pull.


The following changes since commit 3d945be05ac1e806af075e9315bc1b3409adae2b:

  [media] mn88473: simplify bandwidth registers setting code (2015-03-03 13:09:12 -0300)

are available in the git repository at:

  ssh://linuxtv.org/git/sailus/media_tree.git smiapp-dt

for you to fetch changes up to 5f36db86e0cbb48c102fee8a3fe2b98a33f13199:

  smiapp: Use of_property_read_u64_array() to read a 64-bit number array (2015-03-08 00:00:20 +0200)

----------------------------------------------------------------
Sakari Ailus (2):
      Revert "[media] smiapp: Don't compile of_read_number() if CONFIG_OF isn't defined"
      smiapp: Use of_property_read_u64_array() to read a 64-bit number array

 drivers/media/i2c/smiapp/smiapp-core.c |   28 +++++-----------------------
 1 file changed, 5 insertions(+), 23 deletions(-)

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Re: [GIT PULL for v4.1] smiapp DT u64 property workaround removal

[Laurent Pinchart]

Hi Sakari,

On Sunday 08 March 2015 00:06:34 Sakari Ailus wrote:
> Hi Mauro,
> 
> This pull request reverts the smiapp driver's u64 array DT property read
> workaround, and uses of_property_read_u64_array() (second patch) which is
> the correct API function for reading u64 arrays from DT.
> 
> Please pull.
> 
> 
> The following changes since commit 3d945be05ac1e806af075e9315bc1b3409adae2b:
> 
>   [media] mn88473: simplify bandwidth registers setting code (2015-03-03
> 13:09:12 -0300)
> 
> are available in the git repository at:
> 
>   ssh://linuxtv.org/git/sailus/media_tree.git smiapp-dt
> 
> for you to fetch changes up to 5f36db86e0cbb48c102fee8a3fe2b98a33f13199:
> 
>   smiapp: Use of_property_read_u64_array() to read a 64-bit number array
> (2015-03-08 00:00:20 +0200)
> 
> ----------------------------------------------------------------
> Sakari Ailus (2):
>       Revert "[media] smiapp: Don't compile of_read_number() if CONFIG_OF
> isn't defined"
>       smiapp: Use of_property_read_u64_array() to read a 64-bit number array

Won't this cause a bisection breakage if CONFIG_OF isn't enabled ?

>  drivers/media/i2c/smiapp/smiapp-core.c |   28 +++++-----------------------
>  1 file changed, 5 insertions(+), 23 deletions(-)

-- 
Regards,

Laurent Pinchart

Re: [GIT PULL for v4.1] smiapp DT u64 property workaround removal

[Sakari Ailus]

Hi Laurent,

On Sun, Mar 08, 2015 at 01:15:38AM +0200, Laurent Pinchart wrote:
> > Sakari Ailus (2):
> >       Revert "[media] smiapp: Don't compile of_read_number() if CONFIG_OF
> > isn't defined"
> >       smiapp: Use of_property_read_u64_array() to read a 64-bit number array
> 
> Won't this cause a bisection breakage if CONFIG_OF isn't enabled ?

Technically you're right: it does "break" bisect if smiapp is compiled in on
a non-DT platform. Such a platform is not supported in a mainline kernel so
I don't think this is a really major issue.

I could combine the patches if you think this is an issue.

-- 
Regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk

Re: [GIT PULL for v4.1] smiapp DT u64 property workaround removal

[Laurent Pinchart]

Hi Sakari,

On Sunday 08 March 2015 01:20:40 Sakari Ailus wrote:
> On Sun, Mar 08, 2015 at 01:15:38AM +0200, Laurent Pinchart wrote:
> > > Sakari Ailus (2):
> > >       Revert "[media] smiapp: Don't compile of_read_number() if
> > >       CONFIG_OF isn't defined"
> > >       smiapp: Use of_property_read_u64_array() to read a 64-bit number
> > >       array
> > 
> > Won't this cause a bisection breakage if CONFIG_OF isn't enabled ?
> 
> Technically you're right: it does "break" bisect if smiapp is compiled in on
> a non-DT platform. Such a platform is not supported in a mainline kernel so
> I don't think this is a really major issue.
> 
> I could combine the patches if you think this is an issue.

It would break bisection with allmodconfig on non-DT platforms for instance. I 
think combining the two patches would make sense.

-- 
Regards,

Laurent Pinchart

[GIT PULL v2 for v4.1] smiapp DT u64 property workaround removal

[Sakari Ailus]

Hi Mauro,

This pull request reverts the smiapp driver's u64 array DT property read
workaround, and uses of_property_read_u64_array() which is the correct API
function for reading u64 arrays from DT.

since v1:

Based on a discussion with Laurent, I merged the two patches. The commit
message of the second patch remains the same while it includes the revert.

Please pull.


The following changes since commit 3d945be05ac1e806af075e9315bc1b3409adae2b:

  [media] mn88473: simplify bandwidth registers setting code (2015-03-03 13:09:12 -0300)

are available in the git repository at:

  ssh://linuxtv.org/git/sailus/media_tree.git tags/smiapp-dt-2

for you to fetch changes up to e70a7fb677087253b83119ec3033e58a5720f97a:

  smiapp: Use of_property_read_u64_array() to read a 64-bit number array (2015-03-08 01:22:48 +0200)

----------------------------------------------------------------
Sakari Ailus (1):
      smiapp: Use of_property_read_u64_array() to read a 64-bit number array

 drivers/media/i2c/smiapp/smiapp-core.c |   28 +++++-----------------------
 1 file changed, 5 insertions(+), 23 deletions(-)

-- 
Kind regards,

Sakari Ailus
e-mail: sakari.ailus@iki.fi	XMPP: sailus@retiisi.org.uk