From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, sylwester.nawrocki@gmail.com
Subject: Re: [PATCH 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT
Date: Tue, 01 Oct 2013 10:55:04 +0200 [thread overview]
Message-ID: <2921276.foMJNxPg5I@avalon> (raw)
In-Reply-To: <20130930232823.GI3022@valkosipuli.retiisi.org.uk>
Hi Sakari,
On Tuesday 01 October 2013 02:28:23 Sakari Ailus wrote:
> On Tue, Oct 01, 2013 at 01:21:58AM +0200, Laurent Pinchart wrote:
> > On Tuesday 01 October 2013 02:08:47 Sakari Ailus wrote:
> > > On Fri, Sep 20, 2013 at 11:08:47PM +0200, Laurent Pinchart wrote:
> > > > On Thursday 19 September 2013 01:01:05 Sakari Ailus wrote:
> > > > > Pads that set this flag must be connected by an active link for the
> > > > > entity to stream.
> > > > >
> > > > > Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> > > > > Acked-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>
[snip]
> > What about
> >
> > If the pad is linked to any other pad, at least one of the links must be
> > enabled for the entity to be able to stream. There could be temporary
> > reasons (e.g. device configuration dependent) for the pad to need enabled
> > links; the absence of the flag doesn't imply there is none. The flag has
> > no effect on pads without connected links.
>
> Thinking about this again, I'd add before the comma: "and this flag is set".
>
> And if you put it like that then the last sentence is redundat --- I'd drop
> it.
>
> What do you think?
What about
"When this flag is set, if the pad is linked to any other pad then at least
one of those links must be enabled for the entity to be able to stream. There
could be temporary reasons (e.g. device configuration dependent) for the pad
to need enabled links even when this flag isn't set; the absence of the flag
doesn't imply there is none. The flag has no effect on pads without connected
links."
Feel free to drop the last sentence.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-10-01 8:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1379541668-23085-1-git-send-email-sakari.ailus@iki.fi>
[not found] ` <1379541668-23085-2-git-send-email-sakari.ailus@iki.fi>
[not found] ` <30672590.OiMqoca9Fg@avalon>
2013-09-30 23:08 ` [PATCH 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT Sakari Ailus
2013-09-30 23:21 ` Laurent Pinchart
2013-09-30 23:28 ` Sakari Ailus
2013-10-01 8:55 ` Laurent Pinchart [this message]
2013-10-01 9:17 ` Sakari Ailus
2013-10-01 9:22 ` Laurent Pinchart
[not found] ` <22265733.Mjk5afGodv@avalon>
[not found] ` <20130923195702.GA3022@valkosipuli.retiisi.org.uk>
2013-10-01 12:39 ` [PATCH 2/4] media: Check for active links on pads with MEDIA_PAD_FL_MUST_CONNECT flag Laurent Pinchart
2013-10-01 12:52 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2921276.foMJNxPg5I@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sylwester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox