From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 16/29] uvc: fix sparse warning
Date: Mon, 25 Aug 2014 17:02:35 +0200 [thread overview]
Message-ID: <2955863.XgjjzxJM0n@avalon> (raw)
In-Reply-To: <1408575568-20562-17-git-send-email-hverkuil@xs4all.nl>
Hi Hans,
Thank you for the patch.
On Thursday 21 August 2014 00:59:15 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> drivers/media/usb/uvc/uvc_video.c:1466:38: warning: incorrect type in return
> expression (different base types)
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I assume you will push the patch yourself. Please let me know if you would
like me to take it into my tree instead.
> ---
> drivers/media/usb/uvc/uvc_video.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index 9144a2f..7e350d7 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1463,7 +1463,7 @@ static unsigned int uvc_endpoint_max_bpi(struct
> usb_device *dev,
>
> switch (dev->speed) {
> case USB_SPEED_SUPER:
> - return ep->ss_ep_comp.wBytesPerInterval;
> + return le16_to_cpu(ep->ss_ep_comp.wBytesPerInterval);
> case USB_SPEED_HIGH:
> psize = usb_endpoint_maxp(&ep->desc);
> return (psize & 0x07ff) * (1 + ((psize >> 11) & 3));
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-08-25 15:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-20 22:58 [PATCH 00/29] Sparse fixes Hans Verkuil
2014-08-20 22:59 ` [PATCH 01/29] img-ir: fix sparse warnings Hans Verkuil
2014-08-20 23:25 ` James Hogan
2014-08-20 22:59 ` [PATCH 02/29] solo6x10: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 03/29] dibusb: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 04/29] af9015: fix sparse warning Hans Verkuil
2014-08-20 22:59 ` [PATCH 05/29] radio-tea5764: fix sparse warnings Hans Verkuil
2014-08-20 22:59 ` [PATCH 06/29] dw2102: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 07/29] mxl111sf: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 08/29] opera1: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 09/29] pctv452e: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 10/29] go7007: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 11/29] dib7000p: fix sparse warning Hans Verkuil
2014-08-20 22:59 ` [PATCH 12/29] kinect: fix sparse warnings Hans Verkuil
2014-08-21 7:42 ` Antonio Ospite
2014-08-20 22:59 ` [PATCH 13/29] ddbridge: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 14/29] ngene: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 15/29] drxj: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 16/29] uvc: fix sparse warning Hans Verkuil
2014-08-25 15:02 ` Laurent Pinchart [this message]
2014-08-20 22:59 ` [PATCH 17/29] usbtv: fix sparse warnings Hans Verkuil
2014-08-20 22:59 ` [PATCH 18/29] mb86a16/mb86a20s: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 19/29] mantis: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 20/29] wl128x: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 21/29] bcm3510: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 22/29] s2255drv: fix sparse warning Hans Verkuil
2014-08-20 22:59 ` [PATCH 23/29] dvb_usb_core: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 24/29] pwc: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 25/29] stv0367: fix sparse warnings Hans Verkuil
2014-08-20 22:59 ` [PATCH 26/29] si2165: fix sparse warning Hans Verkuil
2014-08-20 22:59 ` [PATCH 27/29] imon: fix sparse warnings Hans Verkuil
2014-08-20 22:59 ` [PATCH 28/29] v4l2-ioctl: " Hans Verkuil
2014-08-20 22:59 ` [PATCH 29/29] lirc_dev: " Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2955863.XgjjzxJM0n@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox