From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF91C7EE23 for ; Wed, 24 May 2023 08:45:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229484AbjEXIp4 (ORCPT ); Wed, 24 May 2023 04:45:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240196AbjEXIpy (ORCPT ); Wed, 24 May 2023 04:45:54 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 953801AC for ; Wed, 24 May 2023 01:45:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684917903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IPjNnsilisJpU1pieN0XK+ygIXwy0O0sWum8P6BGIYA=; b=NWQCOqXzTCwXAmCJxm1NKx94T/+RT+wQvZkWYkpGlpir2l9gzDoykGVahXzzQ2JX0F5zvy 5ipvrdjX8diltUNX+O4QqFbbEeHigsG7SwZfRru9hT0lMtBGM7AnbTYE67AemO+LqXfnIn dvJOKg/0Sg2S5odetMBr/AorVCZxiZY= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-209-WKpzFPdxMTyk54rLUDQfmQ-1; Wed, 24 May 2023 04:45:01 -0400 X-MC-Unique: WKpzFPdxMTyk54rLUDQfmQ-1 Received: by mail-ej1-f70.google.com with SMTP id a640c23a62f3a-9715654ab36so62088466b.0 for ; Wed, 24 May 2023 01:45:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684917900; x=1687509900; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IPjNnsilisJpU1pieN0XK+ygIXwy0O0sWum8P6BGIYA=; b=GOQduSpUMEoC43b6ApLRn/uxjpPKhc+iNYLoMg80+1bD97JgledEALk0ApvGiV6y3U bJlyP32X06rsj3dv/qqKOu3HlmSlKSRL1AUnMGpCd05yTYuGliq+jCbrGCPLpgSizyfB rZbD4CEc1NBmaHZmN5EyP9XPLBMQ/frP9Bv2TiRZzMQ3hp5jGSwP3q4UbM2Am/LAd3v0 tyVdhYkVNpZRpgxeHKMWrxgwagwroUUWCdR+7ykbqsRA2GBwcD6ijysuz04g9pnGR5pt ptfTw/MEcBGd+hWuOoh3TpEIN6ZNik49i6k/eUN4Qv4BK0+tiWEmtxDKA6o3gX5EHxuE sj/g== X-Gm-Message-State: AC+VfDwOq53CyVO60zoVImZ3I1ti1ESAau7+pMtVPkcccj+5P0SvfpCc +/ar1D5fmpzccYfS5X5IFEad1s+GvW4/S+f8CdcrtPOStDuPfbRCm1DFJ84E6YfJezjRE0m1KQ0 lAZtHWgvFvGHqJRkrO3OozAQ= X-Received: by 2002:a17:907:268e:b0:969:f677:11b9 with SMTP id bn14-20020a170907268e00b00969f67711b9mr16410188ejc.54.1684917900415; Wed, 24 May 2023 01:45:00 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4pfcMobEA+3q24rkthAiEr346uOcv7B+ftBoawjPmSRKFqwnlDDi2urafqqQrZpSgY4J+Hww== X-Received: by 2002:a17:907:268e:b0:969:f677:11b9 with SMTP id bn14-20020a170907268e00b00969f67711b9mr16410152ejc.54.1684917900013; Wed, 24 May 2023 01:45:00 -0700 (PDT) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id f25-20020a05640214d900b0050dab547fc6sm4871400edx.74.2023.05.24.01.44.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 24 May 2023 01:44:59 -0700 (PDT) Message-ID: <2bdacc5a-8d8a-159a-780b-5038325ce62f@redhat.com> Date: Wed, 24 May 2023 10:44:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH] staging: Switch i2c drivers back to use .probe() To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Greg Kroah-Hartman Cc: Crt Mori , linux-iio@vger.kernel.org, Tom Rix , Jon Nettleton , Peter Senna Tschudin , Christian Gromm , Jeremy Kerr , Jean Delvare , =?UTF-8?Q?Marek_Beh=c3=ban?= , Lars-Peter Clausen , Haowen Bai , Jens Frederich , linux-staging@lists.linux.dev, Andy Shevchenko , Adrien Grassein , linux-media@vger.kernel.org, =?UTF-8?Q?Niklas_S=c3=b6derlund?= , Michael Hennerich , Kalle Valo , Menna Mahmoud , "Steven Rostedt (Google)" , Parthiban Veerasooran , Mauro Carvalho Chehab , kernel@pengutronix.de, Wolfram Sang , Sakari Ailus , Hans Verkuil , Peter Rosin , Jonathan Cameron References: <20230523200036.465180-1-u.kleine-koenig@pengutronix.de> <20230524060104.wljjqi2ep2ag2245@pengutronix.de> Content-Language: en-US, nl From: Hans de Goede In-Reply-To: <20230524060104.wljjqi2ep2ag2245@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, On 5/24/23 08:01, Uwe Kleine-König wrote: > Hello Hans, > > On Tue, May 23, 2023 at 10:40:43PM +0200, Hans de Goede wrote: >> On 5/23/23 22:00, Uwe Kleine-König wrote: >>> After commit b8a1a4cd5a98 ("i2c: Provide a temporary .probe_new() >>> call-back type"), all drivers being converted to .probe_new() and then >>> 03c835f498b5 ("i2c: Switch .probe() to not take an id parameter") convert >>> back to (the new) .probe() to be able to eventually drop .probe_new() from >>> struct i2c_driver. >>> >>> Signed-off-by: Uwe Kleine-König >>> --- >>> Hello, >>> >>> this patch was generated using coccinelle. >>> >>> I chose to convert all drivers below drivers/staging in a single >>> patch, but if you prefer I can split by driver. >> >> I'm currently doing a lot of cleanup work on the atomisp code >> including the sensor drivers. Specifically I'm working on >> removing drivers which are duplicate with the standard v4l2 >> sensor drivers under drivers/media/i2c . So this patch is >> likely to cause conflicts. >> >> I have my own branch for my atomisp work from which I send >> pull-reqs directly to Mauro Chehab: >> >> https://git.kernel.org/pub/scm/linux/kernel/git/hansg/linux.git/log/?h=media-atomisp >> >> As such I think for the atomisp drivers it would be best if I directly >> apply the atomisp bits of this patch (no need for a resend) to my >> media-atomisp branch, is that ok with you ? > > For me that would be fine, it's mostly Greg who has to cope. As Jonathan > also suggested to split, I suggest I do this. Then everyone can pickup > the usual bits without too much conflicts. That makes sense. I'll wait for your split up version then and then I'll merge the atomisp bits of that version. Regards, Hans