From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19F03C4CEC7 for ; Fri, 13 Sep 2019 00:18:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E08CF206CD for ; Fri, 13 Sep 2019 00:18:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=aj.id.au header.i=@aj.id.au header.b="BQKKVypc"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="N73yuY+I" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727157AbfIMASZ (ORCPT ); Thu, 12 Sep 2019 20:18:25 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42281 "EHLO out3-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725775AbfIMASZ (ORCPT ); Thu, 12 Sep 2019 20:18:25 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C9231218C1; Thu, 12 Sep 2019 20:18:24 -0400 (EDT) Received: from imap2 ([10.202.2.52]) by compute4.internal (MEProxy); Thu, 12 Sep 2019 20:18:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm3; bh=oNwpvvEFJpewbaAAzElh0tbN5tfdwes oAvqCdHyUw20=; b=BQKKVypc07wGv3ETEqiDniu/M41UoqTlRbeyipH149Ckz9H HTZ31Kl6EjyTRRfUZ4/eOINWVA60mIulx/Ap0w8gNCMxDxL1M28X7PEWrY5n8MRf BMYfkD4jVHSVT9hRxCvUepksrTR4d4o1U+1mQQOfPRPFekIcZWZ5pxhYoIaa8nRZ mYZ/Mh5p8HgtubTZJAgOwhhunIURsZN36S/7HbrPXHRnBLJr9RTU+K26zUPO+/GW KJzUeiW70j+UluBkXtiXvGWk1Fe1zRceKk13C/2dZB9dzDCJ1HylswbHiRCiyNMR mAm7PvVcfXMiBPY0kISDz9tfmJQu2lNrohxgQsg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=oNwpvv EFJpewbaAAzElh0tbN5tfdwesoAvqCdHyUw20=; b=N73yuY+IyuOqVQNmQaRPnN xFqjQoGIW6OjoJBzc/g3zzTlYM0jBgi+h+ZnQGm9AX7Rm2X5pmmwxNiMvp6q72yW JrhIg+WqT/JzN7ro2sNXWqhTiJQ1Q7yVKuzL0QV9QLl9o4kg9o9+zeVcqIbfcPbh 1tI1fwsrvt1bDF4+ywWq8aByms/iw+qzvryenH3iPq3x9ahXUKLmPfco6t2HKEp2 s3+bF2WGhgRY/trTmNZMbKF27LDORxJICPMy+deiGZz8gPdPRjzJ4OGRyBP2mJsP hIIPfVrXVWD+2GXvrwKMsgCoGFdZLSy7EwGxN4Gor8gciRwUoQlaBQvTtxrVNyvw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedufedrtdeigdeffecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvufgtsehttdertderreejnecuhfhrohhmpedftehnughr vgifucflvghffhgvrhihfdcuoegrnhgurhgvfiesrghjrdhiugdrrghuqeenucfrrghrrg hmpehmrghilhhfrhhomheprghnughrvgifsegrjhdrihgurdgruhenucevlhhushhtvghr ufhiiigvpedt X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id D9C27E00A9; Thu, 12 Sep 2019 20:18:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.1.7-237-gf35468d-fmstable-20190912v1 Mime-Version: 1.0 Message-Id: <2c24c8a9-b357-4948-8744-3900ed28012c@www.fastmail.com> In-Reply-To: <490bc4d9-e471-3b0f-49c9-39e99af95d62@linux.intel.com> References: <20190910190756.31432-1-jae.hyun.yoo@linux.intel.com> <20190910190756.31432-3-jae.hyun.yoo@linux.intel.com> <5c5538e7-4b7a-4d13-b4ac-584be4090d48@www.fastmail.com> <490bc4d9-e471-3b0f-49c9-39e99af95d62@linux.intel.com> Date: Fri, 13 Sep 2019 09:48:56 +0930 From: "Andrew Jeffery" To: "Jae Hyun Yoo" , "Eddie James" , "Mauro Carvalho Chehab" , "Joel Stanley" Cc: linux-aspeed@lists.ozlabs.org, linux-media@vger.kernel.org, openbmc@lists.ozlabs.org Subject: =?UTF-8?Q?Re:_[PATCH_-next_2/2]_media:_aspeed:_set_hsync_and_vsync_polar?= =?UTF-8?Q?ities_to_normal_before_starting_mode_detection?= Content-Type: text/plain Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org On Fri, 13 Sep 2019, at 02:36, Jae Hyun Yoo wrote: > On 9/11/2019 10:39 PM, Andrew Jeffery wrote: > > > > > > On Wed, 11 Sep 2019, at 04:37, Jae Hyun Yoo wrote: > >> Sometimes it detects a weird resolution such as 1024x287 when the > >> actual resolution is 1024x768. To resolve such an issue, this > >> commit adds clearing for hsync and vsync polarity register bits > >> at the beginning of the first mode detection. This is recommended > >> in the datasheet. > > > > I guess this answers my question on the previous patch's commit > > message. Maybe it should be in both? > > I think the previous patch is a bug fix and this one is an enhancement > patch. Better splitting them. I wasn't suggesting squashing the patches, I was suggesting updating the commit message of the first patch to better justify/explain the change. Andrew