Re: [PATCH v1 06/11] media: starfive: add ISP driver files

Krzysztof Kozlowski
2023-03-08T10:35:34Z

On 07/03/2023 10:53, Jack Zhu wrote:
>
>
> On 2023/3/3 16:45, Krzysztof Kozlowski wrote:
>> On 02/03/2023 10:19, jack.zhu wrote:
>>> Add base driver for Starfive Image Signal Processing Unit which
>>> handles the data streams from the CSI2 receiver.
>>>
>>> Signed-off-by: jack.zhu <jack.zhu@starfivetech.com>
>>> ---
>>> drivers/media/platform/starfive/stf_isp.c | 1079 ++++++++++++++
>>> drivers/media/platform/starfive/stf_isp.h | 183 +++
>>> .../media/platform/starfive/stf_isp_hw_ops.c | 1286 +++++++++++++++++
>>> 3 files changed, 2548 insertions(+)
>>> create mode 100644 drivers/media/platform/starfive/stf_isp.c
>>> create mode 100644 drivers/media/platform/starfive/stf_isp.h
>>> create mode 100644 drivers/media/platform/starfive/stf_isp_hw_ops.c
>>
>>
>>> +}
>>> +
>>> +static int stf_isp_reg_read(struct stf_isp_dev *isp_dev, void *arg)
>>> +{
>>> + void __iomem *ispbase = stf_isp_get_ispbase(isp_dev);
>>> + struct isp_reg_param *reg_param = arg;
>>
>>
>> Didn't you add now code which does not even build and is not bisectable?
>>
>
> use patch 11 to build all files in the starfive directory.
>

Not related. So let me put it very simple:

1. Does this code build or not?
2. Do you certify that code is 100% bisectable?

Best regards,
Krzysztof