From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:37705 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754391Ab2ENHa2 (ORCPT ); Mon, 14 May 2012 03:30:28 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org Subject: Re: [PATCH 0/3] V4L2_CID_PIXEL_RATE support in sensor drivers Date: Mon, 14 May 2012 09:30:32 +0200 Message-ID: <3000181.vkxHx4XP90@avalon> In-Reply-To: <20120513215335.GF3373@valkosipuli.retiisi.org.uk> References: <1336568159-23378-1-git-send-email-laurent.pinchart@ideasonboard.com> <20120513215335.GF3373@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, On Monday 14 May 2012 00:53:36 Sakari Ailus wrote: > On Wed, May 09, 2012 at 02:55:56PM +0200, Laurent Pinchart wrote: > > Hi everybody, > > > > This patch implements support for the V4L2_CID_PIXEL_RATE control in the > > mt9t001, mt9p031 and mt9m032 sensor drivers. > > > > Recent changes to the OMAP3 ISP driver (see the media-for-3.5 branch in > > the http://git.linuxtv.org/sailus/media_tree.git repository) made support > > for that control mandatory for sensor drivers that are to be used with the > > OMAP3 ISP. > > > > Sakari, would you like to take these patches in your tree and push them > > for v3.5 ? V4L2_CID_PIXEL_RATE support for the mt9v032 driver is also > > still missing, the patch you've sent to the list two months ago needs to > > be rebased. Will you do that or should I do it ? I'm also wondering > > whether that patch shouldn't mark the V4L2_CID_PIXEL_RATE control as > > volatile, calling v4l2_s_ext_ctrls() from inside the driver looks quite > > hackish to> me. The alternative would be to create a 64-bit version of > > v4l2_ctrl_s_ctrl(). > > > > Laurent Pinchart (3): > > mt9t001: Implement V4L2_CID_PIXEL_RATE control > > mt9p031: Implement V4L2_CID_PIXEL_RATE control > > mt9m032: Implement V4L2_CID_PIXEL_RATE control > > > > drivers/media/video/mt9m032.c | 13 +++++++++++-- > > drivers/media/video/mt9p031.c | 5 ++++- > > drivers/media/video/mt9t001.c | 13 +++++++++++-- > > include/media/mt9t001.h | 1 + > > 4 files changed, 27 insertions(+), 5 deletions(-) > > Acked-by: Sakari Ailus Thank you. Ad the patches depend on the V4L2_CID_PIXEL_RATE control, could you please take them in your tree and push them for v3.5 ? -- Regards, Laurent Pinchart