From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:37920 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751719Ab3G3LPy (ORCPT ); Tue, 30 Jul 2013 07:15:54 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, linux-sh@vger.kernel.org, Hans Verkuil , Katsuya MATSUBARA , Sylwester Nawrocki Subject: Re: [PATCH v3 4/5] v4l: Add V4L2_PIX_FMT_NV16M and V4L2_PIX_FMT_NV61M formats Date: Tue, 30 Jul 2013 13:16:54 +0200 Message-ID: <3004984.tPvT1zp9Z5@avalon> In-Reply-To: <20130730110934.GN12281@valkosipuli.retiisi.org.uk> References: <1374757213-20194-1-git-send-email-laurent.pinchart@ideasonboard.com> <1374757213-20194-5-git-send-email-laurent.pinchart@ideasonboard.com> <20130730110934.GN12281@valkosipuli.retiisi.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the review. On Tuesday 30 July 2013 14:09:34 Sakari Ailus wrote: > On Thu, Jul 25, 2013 at 03:00:12PM +0200, Laurent Pinchart wrote: > > From: Laurent Pinchart > > > > NV16M and NV61M are planar YCbCr 4:2:2 and YCrCb 4:2:2 formats with a > > luma plane followed by an interleaved chroma plane. The planes are not > > required to be contiguous in memory, and the formats can only be used > > with the multi-planar formats API. > > > > Signed-off-by: Laurent Pinchart > > > > Reviewed-by: Sylwester Nawrocki > > --- > > > > Documentation/DocBook/media/v4l/pixfmt-nv16m.xml | 170 ++++++++++++++++++ > > Documentation/DocBook/media/v4l/pixfmt.xml | 1 + > > include/uapi/linux/videodev2.h | 2 + > > 3 files changed, 173 insertions(+) > > create mode 100644 Documentation/DocBook/media/v4l/pixfmt-nv16m.xml > > > > diff --git a/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml > > b/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml new file mode 100644 > > index 0000000..84a8bb3 > > --- /dev/null > > +++ b/Documentation/DocBook/media/v4l/pixfmt-nv16m.xml > > @@ -0,0 +1,170 @@ > > + > > + > > + V4L2_PIX_FMT_NV16M ('NM16'), V4L2_PIX_FMT_NV61M > > ('NM61') + &manvol; > > + > > + > > + > id="V4L2-PIX-FMT-NV16M">V4L2_PIX_FMT_NV16M > > + > id="V4L2-PIX-FMT-NV61M">V4L2_PIX_FMT_NV61M > > + Variation of V4L2_PIX_FMT_NV16 and > > V4L2_PIX_FMT_NV61 with planes + non contiguous in > > memory. > > + > > + > > + Description > > + > > + This is a multi-planar, two-plane version of the YUV 4:2:0 format. > > +The three components are separated into two sub-images or planes. > > +V4L2_PIX_FMT_NV16M differs from > > V4L2_PIX_FMT_NV16 + in that the two planes are > > non-contiguous in memory, i.e. the chroma +plane do not necessarily > > immediately follows the luma plane. > > +The luminance data occupies the first plane. The Y plane has one byte per > > pixel. +In the second plane there is a chrominance data with alternating > > chroma samples. +The CbCr plane is the same width and height, in bytes, > > as the Y plane. +Each CbCr pair belongs to four pixels. For example, > > +Cb0/Cr0 belongs to > > +Y'00, Y'01, > > +Y'10, Y'11. > > +V4L2_PIX_FMT_NV61M is the same as > > V4L2_PIX_FMT_NV16M +except the Cb and Cr bytes are > > swapped, the CrCb plane starts with a Cr byte. + > > + V4L2_PIX_FMT_NV16M is intended to be > > +used only in drivers and applications that support the multi-planar API, > > +described in . > > I think you could refer to V4L2_PIX_FMT_NV61M or alternatively move the > sentence explaining V4L2_PIX_FMT_NV61M after the above. Up to you. Something like V4L2_PIX_FMT_NV16M and V4L2_PIX_FMT_NV61M are intended to be used only in drivers and applications that support the multi-planar API, described in . ? > Reviewed-by: Sakari Ailus -- Regards, Laurent Pinchart