From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joe Perches <joe@perches.com>
Cc: Mauro Carvalho Chehab <m.chehab@samsung.com>,
Paul Bolle <pebolle@tiscali.nl>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag
Date: Thu, 06 Mar 2014 02:27:46 +0100 [thread overview]
Message-ID: <3032500.9J1uSX3lel@avalon> (raw)
In-Reply-To: <1394067637.12070.36.camel@joe-AO722>
Hi Joe,
On Wednesday 05 March 2014 17:00:37 Joe Perches wrote:
> On Thu, 2014-03-06 at 01:48 +0100, Laurent Pinchart wrote:
> > Would you recommend to drop driver-specific Kconfig options related to
> > debugging and use CONFIG_DYNAMIC_DEBUG instead ?
>
> For development, sure, if there's sufficient memory.
>
> For embedded systems with limited memory, using dynamic_debug isn't always
> possible or effective.
>
> Also, there are sometimes reasons to have debugging messages always enabled
> or emitted.
>
> For those cases, either adding #define DEBUG or using printk(KERN_DEBUG
> would be fine.
My goal here is to offer an easy way for users to enable debugging without
requiring changes to the source code. The driver includes various dev_dbg()
messages, I don't want to ask people reporting problems to turn them into
printk() calls :-) Even adding #define DEBUG at the beginning of the source
files is likely too error prone for users without much programming experience.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-03-06 1:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-09 15:09 [PATCH] [media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG Paul Bolle
2014-02-10 14:13 ` Laurent Pinchart
2014-02-10 15:13 ` Paul Bolle
2014-02-10 15:29 ` Laurent Pinchart
2014-02-11 11:17 ` [PATCH v2] [media] v4l: omap4iss: Add DEBUG compiler flag Paul Bolle
2014-02-11 12:38 ` Laurent Pinchart
2014-03-05 20:10 ` Mauro Carvalho Chehab
2014-03-05 23:50 ` Laurent Pinchart
2014-03-06 0:28 ` Joe Perches
2014-03-06 0:48 ` Laurent Pinchart
2014-03-06 1:00 ` Joe Perches
2014-03-06 1:27 ` Laurent Pinchart [this message]
2014-03-06 1:35 ` Joe Perches
2014-03-06 1:52 ` Laurent Pinchart
2014-03-06 3:25 ` Joe Perches
2014-03-06 10:55 ` Laurent Pinchart
2014-03-06 16:47 ` Joe Perches
2014-03-06 4:45 ` Greg Kroah-Hartman
2014-03-06 10:23 ` Paul Bolle
2014-03-06 11:00 ` Laurent Pinchart
2014-03-06 11:59 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3032500.9J1uSX3lel@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=m.chehab@samsung.com \
--cc=pebolle@tiscali.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox