From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:35309 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756010Ab2DIJvD (ORCPT ); Mon, 9 Apr 2012 05:51:03 -0400 From: Laurent Pinchart To: Guennadi Liakhovetski Cc: Linux Media Mailing List Subject: Re: [PATCH] V4L: mt9m032: fix two dead-locks Date: Mon, 09 Apr 2012 11:51:04 +0200 Message-ID: <3076345.89Inf54hBS@avalon> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Guennadi, Thanks for the patch. On Sunday 08 April 2012 22:31:24 Guennadi Liakhovetski wrote: > Fix a copy-paste typo and a nested locking function call in mt9m032. > > Signed-off-by: Guennadi Liakhovetski Acked-by: Laurent Pinchart and applied to my tree. > --- > drivers/media/video/mt9m032.c | 5 +++-- > 1 files changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/video/mt9m032.c b/drivers/media/video/mt9m032.c > index 7636672..645973c 100644 > --- a/drivers/media/video/mt9m032.c > +++ b/drivers/media/video/mt9m032.c > @@ -392,10 +392,11 @@ static int mt9m032_set_pad_format(struct v4l2_subdev > *subdev, } > > /* Scaling is not supported, the format is thus fixed. */ > - ret = mt9m032_get_pad_format(subdev, fh, fmt); > + fmt->format = *__mt9m032_get_pad_format(sensor, fh, fmt->which); > + ret = 0; > > done: > - mutex_lock(&sensor->lock); > + mutex_unlock(&sensor->lock); > return ret; > } -- Regards, Laurent Pinchart