* [PATCH] V4L: mt9m032: fix two dead-locks
@ 2012-04-08 20:31 Guennadi Liakhovetski
2012-04-09 9:51 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Guennadi Liakhovetski @ 2012-04-08 20:31 UTC (permalink / raw)
To: Linux Media Mailing List; +Cc: Laurent Pinchart
Fix a copy-paste typo and a nested locking function call in mt9m032.
Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
---
drivers/media/video/mt9m032.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/media/video/mt9m032.c b/drivers/media/video/mt9m032.c
index 7636672..645973c 100644
--- a/drivers/media/video/mt9m032.c
+++ b/drivers/media/video/mt9m032.c
@@ -392,10 +392,11 @@ static int mt9m032_set_pad_format(struct v4l2_subdev *subdev,
}
/* Scaling is not supported, the format is thus fixed. */
- ret = mt9m032_get_pad_format(subdev, fh, fmt);
+ fmt->format = *__mt9m032_get_pad_format(sensor, fh, fmt->which);
+ ret = 0;
done:
- mutex_lock(&sensor->lock);
+ mutex_unlock(&sensor->lock);
return ret;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] V4L: mt9m032: fix two dead-locks
2012-04-08 20:31 [PATCH] V4L: mt9m032: fix two dead-locks Guennadi Liakhovetski
@ 2012-04-09 9:51 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2012-04-09 9:51 UTC (permalink / raw)
To: Guennadi Liakhovetski; +Cc: Linux Media Mailing List
Hi Guennadi,
Thanks for the patch.
On Sunday 08 April 2012 22:31:24 Guennadi Liakhovetski wrote:
> Fix a copy-paste typo and a nested locking function call in mt9m032.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/media/video/mt9m032.c | 5 +++--
> 1 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/media/video/mt9m032.c b/drivers/media/video/mt9m032.c
> index 7636672..645973c 100644
> --- a/drivers/media/video/mt9m032.c
> +++ b/drivers/media/video/mt9m032.c
> @@ -392,10 +392,11 @@ static int mt9m032_set_pad_format(struct v4l2_subdev
> *subdev, }
>
> /* Scaling is not supported, the format is thus fixed. */
> - ret = mt9m032_get_pad_format(subdev, fh, fmt);
> + fmt->format = *__mt9m032_get_pad_format(sensor, fh, fmt->which);
> + ret = 0;
>
> done:
> - mutex_lock(&sensor->lock);
> + mutex_unlock(&sensor->lock);
> return ret;
> }
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-04-09 9:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-04-08 20:31 [PATCH] V4L: mt9m032: fix two dead-locks Guennadi Liakhovetski
2012-04-09 9:51 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).