From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv2 API PATCH 25/28] Set vfl_dir for all display or m2m drivers.
Date: Thu, 13 Sep 2012 04:37:27 +0200 [thread overview]
Message-ID: <3121560.nicC2eVh8j@avalon> (raw)
In-Reply-To: <4b07ee5a399746f4264f852f430dbbcae8a13b32.1347023744.git.hans.verkuil@cisco.com>
Hi Hans,
Thanks for the patch.
On Friday 07 September 2012 15:29:25 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> ---
> drivers/media/pci/ivtv/ivtv-streams.c | 3 +++
> drivers/media/pci/zoran/zoran_card.c | 4 ++++
> drivers/media/platform/coda.c | 1 +
> drivers/media/platform/davinci/vpbe_display.c | 1 +
> drivers/media/platform/davinci/vpif_display.c | 1 +
> drivers/media/platform/m2m-deinterlace.c | 1 +
> drivers/media/platform/mem2mem_testdev.c | 1 +
> drivers/media/platform/mx2_emmaprp.c | 1 +
> drivers/media/platform/omap/omap_vout.c | 1 +
> drivers/media/platform/omap3isp/ispvideo.c | 1 +
> drivers/media/platform/s5p-fimc/fimc-m2m.c | 1 +
> drivers/media/platform/s5p-g2d/g2d.c | 1 +
> drivers/media/platform/s5p-jpeg/jpeg-core.c | 1 +
> drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 +
> drivers/media/platform/s5p-tv/mixer_video.c | 1 +
> drivers/media/platform/sh_vou.c | 1 +
> drivers/media/usb/uvc/uvc_driver.c | 2 ++
> 17 files changed, 23 insertions(+)
>
> diff --git a/drivers/media/pci/ivtv/ivtv-streams.c
> b/drivers/media/pci/ivtv/ivtv-streams.c index f08ec17..1d0e04a 100644
> --- a/drivers/media/pci/ivtv/ivtv-streams.c
> +++ b/drivers/media/pci/ivtv/ivtv-streams.c
> @@ -223,6 +223,9 @@ static int ivtv_prep_dev(struct ivtv *itv, int type)
>
> s->vdev->num = num;
> s->vdev->v4l2_dev = &itv->v4l2_dev;
> + if (ivtv_stream_info[type].buf_type == V4L2_BUF_TYPE_VIDEO_OUTPUT ||
> + ivtv_stream_info[type].buf_type == V4L2_BUF_TYPE_VBI_OUTPUT)
> + s->vdev->vfl_dir = VFL_DIR_TX;
I think drivers should set VFL_DIR_RX explicitly instead of relying on it
being equal to 0. If we change the value later for any reason this
implementation would break.
> s->vdev->fops = ivtv_stream_info[type].fops;
> s->vdev->ctrl_handler = itv->v4l2_dev.ctrl_handler;
> s->vdev->release = video_device_release;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-09-13 10:16 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 13:29 [RFCv2 API PATCH 00/28] Full series of API fixes from the 2012 Media Workshop Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 01/28] v4l: Remove experimental tag from certain API elements Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 02/28] videodev2.h: split off controls into v4l2-controls.h Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 03/28] DocBook: improve STREAMON/OFF documentation Hans Verkuil
2012-09-07 19:58 ` Sylwester Nawrocki
2012-09-13 2:17 ` Laurent Pinchart
2012-09-07 13:29 ` [RFCv2 API PATCH 04/28] DocBook: make the G/S/TRY_FMT specification more strict Hans Verkuil
2012-09-07 20:00 ` Sylwester Nawrocki
2012-09-13 2:18 ` Laurent Pinchart
2012-09-07 13:29 ` [RFCv2 API PATCH 05/28] DocBook: bus_info can no longer be empty Hans Verkuil
2012-09-07 20:00 ` Sylwester Nawrocki
2012-09-08 11:15 ` Hans Verkuil
2012-09-08 14:19 ` Sylwester Nawrocki
2012-09-09 8:45 ` Hans Verkuil
2012-09-09 14:01 ` Sylwester Nawrocki
2012-09-13 1:24 ` Laurent Pinchart
2012-09-13 10:40 ` Hans Verkuil
2012-09-19 18:46 ` Laurent Pinchart
2012-09-20 6:38 ` Hans Verkuil
2012-09-20 13:24 ` Laurent Pinchart
2012-09-07 13:29 ` [RFCv2 API PATCH 06/28] v4l2-core: deprecate V4L2_BUF_TYPE_PRIVATE Hans Verkuil
2012-09-13 2:21 ` Laurent Pinchart
2012-09-13 10:46 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 07/28] DocBook: " Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 08/28] v4l2: remove experimental tag from a number of old drivers Hans Verkuil
2012-09-07 20:04 ` Sylwester Nawrocki
2012-09-07 13:29 ` [RFCv2 API PATCH 09/28] DocBook: document when to return ENODATA Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 10/28] Rename V4L2_(IN|OUT)_CAP_CUSTOM_TIMINGS Hans Verkuil
2012-09-13 2:22 ` Laurent Pinchart
2012-09-13 10:47 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 11/28] DocBook: fix awkward language and fix the documented return value Hans Verkuil
2012-09-07 20:08 ` Sylwester Nawrocki
2012-09-07 13:29 ` [RFCv2 API PATCH 12/28] v4l2-core: Add new V4L2_CAP_MONOTONIC_TS capability Hans Verkuil
2012-09-07 20:11 ` Sylwester Nawrocki
2012-09-13 2:26 ` Laurent Pinchart
2012-09-13 20:38 ` Sakari Ailus
2012-09-13 20:50 ` Laurent Pinchart
2012-09-13 20:56 ` Hans Verkuil
2012-09-14 9:02 ` Sakari Ailus
2012-09-14 9:21 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 13/28] Add V4L2_CAP_MONOTONIC_TS where applicable Hans Verkuil
2012-09-07 20:15 ` Sylwester Nawrocki
2012-09-08 14:33 ` Rémi Denis-Courmont
2012-09-09 8:46 ` Hans Verkuil
2012-09-13 1:27 ` Laurent Pinchart
2012-09-07 13:29 ` [RFCv2 API PATCH 14/28] DocBook: clarify that sequence is also set for output devices Hans Verkuil
2012-09-07 20:18 ` Sylwester Nawrocki
2012-09-13 2:28 ` Laurent Pinchart
2012-09-13 10:48 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 15/28] DocBook: Mark CROPCAP as optional instead of as compulsory Hans Verkuil
2012-09-13 2:32 ` Laurent Pinchart
2012-09-07 13:29 ` [RFCv2 API PATCH 16/28] v4l2: make vidioc_s_fbuf const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 17/28] v4l2: make vidioc_s_jpegcomp const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 18/28] v4l2: make vidioc_s_freq_hw_seek const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 19/28] v4l2: make vidioc_(un)subscribe_event const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 20/28] v4l2: make vidioc_s_audio const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 21/28] v4l2: make vidioc_s_audout const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 22/28] v4l2: make vidioc_s_modulator const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 23/28] v4l2: make vidioc_s_crop const Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 24/28] v4l2-dev: add new VFL_DIR_ defines Hans Verkuil
2012-09-13 2:36 ` Laurent Pinchart
2012-09-13 10:54 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 25/28] Set vfl_dir for all display or m2m drivers Hans Verkuil
2012-09-13 2:37 ` Laurent Pinchart [this message]
2012-09-13 10:56 ` Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 26/28] v4l2-dev: improve ioctl validity checks Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 27/28] v4l2-dev: reorder checks into blocks of ioctls with similar properties Hans Verkuil
2012-09-07 13:29 ` [RFCv2 API PATCH 28/28] Add vfl_dir field documentation Hans Verkuil
2012-09-07 13:59 ` [RFCv2 API PATCH 00/28] Full series of API fixes from the 2012 Media Workshop Devin Heitmueller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3121560.nicC2eVh8j@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).