From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vincent ABRIOU <vincent.abriou@st.com>
Cc: "linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
Benjamin Gaignard <benjamin.gaignard@linaro.org>,
Hugues FRUCHET <hugues.fruchet@st.com>,
Jean Christophe TROTIN <jean-christophe.trotin@st.com>,
Nicolas Dufresne <nicolas.dufresne@collabora.com>
Subject: Re: [media] uvcvideo: support for contiguous DMA buffers
Date: Mon, 09 Jan 2017 18:59:09 +0200 [thread overview]
Message-ID: <3193570.QBsjjzBjh2@avalon> (raw)
In-Reply-To: <c86650e5-7106-d36b-b716-6247fb2fa8ed@st.com>
Hi Vincent,
(CC'ing Nicolas)
On Monday 09 Jan 2017 15:49:00 Vincent ABRIOU wrote:
> On 01/09/2017 04:37 PM, Laurent Pinchart wrote:
> > Hi Vincent,
> >
> > Thank you for the patch.
> >
> > On Monday 03 Oct 2016 13:27:16 Vincent Abriou wrote:
> >> Allow uvcvideo compatible devices to allocate their output buffers using
> >> contiguous DMA buffers.
> >
> > Why do you need this ? If it's for buffer sharing with a device that
> > requires dma-contig, can't you allocate the buffers on the other device
> > and import them on the UVC side ?
>
> Hi Laurent,
>
> I need this using Gstreamer simple pipeline to connect an usb webcam
> (v4l2src) with a display (waylandsink) activating the zero copy path.
>
> The waylandsink plugin does not have any contiguous memory pool to
> allocate contiguous buffer. So it is up to the upstream element, here
> v4l2src, to provide such contiguous buffers.
Isn't that a gstreamer issue ?
> >> Add the "allocators" module parameter option to let uvcvideo use the
> >> dma-contig instead of vmalloc.
> >>
> >> Signed-off-by: Vincent Abriou <vincent.abriou@st.com>
> >> ---
> >>
> >> Documentation/media/v4l-drivers/uvcvideo.rst | 12 ++++++++++++
> >> drivers/media/usb/uvc/Kconfig | 2 ++
> >> drivers/media/usb/uvc/uvc_driver.c | 3 ++-
> >> drivers/media/usb/uvc/uvc_queue.c | 23 ++++++++++++++++++---
> >> drivers/media/usb/uvc/uvcvideo.h | 4 ++--
> >> 5 files changed, 38 insertions(+), 6 deletions(-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-01-09 16:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-03 11:27 [media] uvcvideo: support for contiguous DMA buffers Vincent Abriou
2016-11-03 12:58 ` Vincent ABRIOU
2017-01-09 15:37 ` Laurent Pinchart
2017-01-09 15:49 ` Vincent ABRIOU
2017-01-09 16:59 ` Laurent Pinchart [this message]
2017-01-10 8:55 ` Vincent ABRIOU
2017-01-10 14:41 ` Laurent Pinchart
2017-01-10 14:53 ` Vincent ABRIOU
2017-01-11 11:03 ` Sakari Ailus
2017-01-11 12:36 ` Vincent ABRIOU
2017-01-25 11:46 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3193570.QBsjjzBjh2@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=benjamin.gaignard@linaro.org \
--cc=hugues.fruchet@st.com \
--cc=jean-christophe.trotin@st.com \
--cc=linux-media@vger.kernel.org \
--cc=nicolas.dufresne@collabora.com \
--cc=vincent.abriou@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox