From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:49263 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752474AbbBWQpi (ORCPT ); Mon, 23 Feb 2015 11:45:38 -0500 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Hans Verkuil Subject: Re: [PATCH 7/7] DocBook media: document the new 'which' field. Date: Mon, 23 Feb 2015 18:46:40 +0200 Message-ID: <3196637.eIdTnyjkZV@avalon> In-Reply-To: <1423827006-32878-8-git-send-email-hverkuil@xs4all.nl> References: <1423827006-32878-1-git-send-email-hverkuil@xs4all.nl> <1423827006-32878-8-git-send-email-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patch. On Friday 13 February 2015 12:30:06 Hans Verkuil wrote: > From: Hans Verkuil > > The subdev enum ioctls now have a new 'which' field. Document this. > > Signed-off-by: Hans Verkuil Acked-by: Laurent Pinchart > --- > .../DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml | 13 ++++++---- > .../DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml | 13 ++++++---- > .../DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml | 11 +++++++--- 3 files changed, 26 insertions(+), 11 deletions(-) > > diff --git > a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml > b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml > index 2f8f4f0..cff59f5 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-interval.xml > @@ -67,9 +67,9 @@ > > To enumerate frame intervals applications initialize the > index, pad, > - code, width and > - height fields of > - &v4l2-subdev-frame-interval-enum; and call the > + which, code, > + width and height > + fields of &v4l2-subdev-frame-interval-enum; and call the > VIDIOC_SUBDEV_ENUM_FRAME_INTERVAL ioctl with a > pointer to this structure. Drivers fill the rest of the structure or return > an &EINVAL; if one of the input fields is invalid. All frame intervals are > @@ -123,7 +123,12 @@ > > > __u32 > - reserved[9] > + which > + Frame intervals to be enumerated, from > &v4l2-subdev-format-whence;. + > + > + __u32 > + reserved[8] > Reserved for future extensions. Applications and drivers must > set the array to zero. > > diff --git > a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml > b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml index > 79ce42b..abd545e 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-frame-size.xml > @@ -61,9 +61,9 @@ > ioctl. > > To enumerate frame sizes applications initialize the > - pad, code and > - index fields of the > - &v4l2-subdev-mbus-code-enum; and call the > + pad, which , > + code and index > + fields of the &v4l2-subdev-mbus-code-enum; and call the > VIDIOC_SUBDEV_ENUM_FRAME_SIZE ioctl with a pointer > to the structure. Drivers fill the minimum and maximum frame sizes or > return an &EINVAL; if one of the input parameters is invalid. @@ > -127,7 +127,12 @@ > > > __u32 > - reserved[9] > + which > + Frame sizes to be enumerated, from > &v4l2-subdev-format-whence;. + > + > + __u32 > + reserved[8] > Reserved for future extensions. Applications and drivers must > set the array to zero. > > diff --git > a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml > b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml index > a6b3432..0bcb278 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-subdev-enum-mbus-code.xml > @@ -56,8 +56,8 @@ > > > To enumerate media bus formats available at a given sub-device > pad - applications initialize the pad and - > index fields of &v4l2-subdev-mbus-code-enum; > and + applications initialize the pad, > which + and index > fields of &v4l2-subdev-mbus-code-enum; and call the > VIDIOC_SUBDEV_ENUM_MBUS_CODE ioctl with a pointer to > this structure. Drivers fill the rest of the structure or return an > &EINVAL; if either the pad or > @@ -93,7 +93,12 @@ > > > __u32 > - reserved[9] > + which > + Media bus format codes to be enumerated, from > &v4l2-subdev-format-whence;. + > + > + __u32 > + reserved[8] > Reserved for future extensions. Applications and drivers must > set the array to zero. > -- Regards, Laurent Pinchart