Re: [PATCH 54/57] [media] platform: don't break long lines

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Mauro,

Thank you for the patch.

On Friday 14 Oct 2016 17:20:42 Mauro Carvalho Chehab wrote:
> Due to the 80-cols checkpatch warnings, several strings
> were broken into multiple lines. This is not considered
> a good practice anymore, as it makes harder to grep for
> strings at the source code. So, join those continuation
> lines.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
>  drivers/media/platform/mx2_emmaprp.c | 3 +--
>  drivers/media/platform/pxa_camera.c  | 6 ++----
>  drivers/media/platform/via-camera.c  | 7 ++-----
>  3 files changed, 5 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/media/platform/mx2_emmaprp.c
> b/drivers/media/platform/mx2_emmaprp.c index e68d271b10af..ea572718a638
> 100644
> --- a/drivers/media/platform/mx2_emmaprp.c
> +++ b/drivers/media/platform/mx2_emmaprp.c
> @@ -724,8 +724,7 @@ static int emmaprp_buf_prepare(struct vb2_buffer *vb)
>  	q_data = get_q_data(ctx, vb->vb2_queue->type);
> 
>  	if (vb2_plane_size(vb, 0) < q_data->sizeimage) {
> -		dprintk(ctx->dev, "%s data will not fit into plane"
> -				  "(%lu < %lu)\n", __func__,
> +		dprintk(ctx->dev, "%s data will not fit into plane(%lu < 
%lu)\n",
> __func__, vb2_plane_size(vb, 0),
>  				  (long)q_data->sizeimage);

If you really want to perform such a change, let's not make lines 
unnecessarily long either. You should add a line break after the first and 
second argument:

		dprintk(ctx->dev,
			"%s data will not fit into plane(%lu < %lu)\n",
			__func__, vb2_plane_size(vb, 0),
			(long)q_data->sizeimage);

And everything will fit in 80 columns.

>  		return -EINVAL;
> diff --git a/drivers/media/platform/pxa_camera.c
> b/drivers/media/platform/pxa_camera.c index c12209c701d3..bcdac4932fb1
> 100644
> --- a/drivers/media/platform/pxa_camera.c
> +++ b/drivers/media/platform/pxa_camera.c
> @@ -2347,8 +2347,7 @@ static int pxa_camera_probe(struct platform_device
> *pdev) * Platform hasn't set available data widths. This is bad.
>  		 * Warn and use a default.
>  		 */
> -		dev_warn(&pdev->dev, "WARNING! Platform hasn't set available "
> -			 "data widths, using default 10 bit\n");
> +		dev_warn(&pdev->dev, "WARNING! Platform hasn't set available 
data widths,
> using default 10 bit\n");

Same comment here, you should add a line break after the first argument.

I assume the same comment applied to the 56 other patches in the series.

> 		pcdev->platform_flags |= PXA_CAMERA_DATAWIDTH_10;
>  	}
>  	if (pcdev->platform_flags & PXA_CAMERA_DATAWIDTH_8)
> @@ -2359,8 +2358,7 @@ static int pxa_camera_probe(struct platform_device
> *pdev) pcdev->width_flags |= 1 << 9;
>  	if (!pcdev->mclk) {
>  		dev_warn(&pdev->dev,
> -			 "mclk == 0! Please, fix your platform data. "
> -			 "Using default 20MHz\n");
> +			 "mclk == 0! Please, fix your platform data. Using 
default 20MHz\n");
>  		pcdev->mclk = 20000000;
>  	}
> 
> diff --git a/drivers/media/platform/via-camera.c
> b/drivers/media/platform/via-camera.c index 7ca12deba89c..e16f70a5df1d
> 100644
> --- a/drivers/media/platform/via-camera.c
> +++ b/drivers/media/platform/via-camera.c
> @@ -39,15 +39,12 @@ MODULE_LICENSE("GPL");
>  static bool flip_image;
>  module_param(flip_image, bool, 0444);
>  MODULE_PARM_DESC(flip_image,
> -		"If set, the sensor will be instructed to flip the image "
> -		"vertically.");
> +		"If set, the sensor will be instructed to flip the image 
vertically.");
> 
>  static bool override_serial;
>  module_param(override_serial, bool, 0444);
>  MODULE_PARM_DESC(override_serial,
> -		"The camera driver will normally refuse to load if "
> -		"the XO 1.5 serial port is enabled.  Set this option "
> -		"to force-enable the camera.");
> +		"The camera driver will normally refuse to load if the XO 1.5 
serial port
> is enabled.  Set this option to force-enable the camera.");
> 
>  /*
>   * The structure describing our camera.

-- 
Regards,

Laurent Pinchart