* [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam
@ 2013-04-15 19:01 Kamal Mostafa
2013-04-16 23:05 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Kamal Mostafa @ 2013-04-15 19:01 UTC (permalink / raw)
To: linux-media, linux-kernel, Laurent Pinchart,
Mauro Carvalho Chehab
Cc: Kamal Mostafa
BugLink: https://bugs.launchpad.net/bugs/1168430
OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the
same UVC_QUIRK_PROBE_DEF as other OmniVision model to be recognized
consistently.
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
---
drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/media/usb/uvc/uvc_driver.c b/drivers/media/usb/uvc/uvc_driver.c
index 5dbefa6..17bd48d 100644
--- a/drivers/media/usb/uvc/uvc_driver.c
+++ b/drivers/media/usb/uvc/uvc_driver.c
@@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = {
.bInterfaceSubClass = 1,
.bInterfaceProtocol = 0,
.driver_info = UVC_QUIRK_PROBE_DEF },
+ /* Dell Studio Hybrid 140g (OmniVision webcam) */
+ { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
+ | USB_DEVICE_ID_MATCH_INT_INFO,
+ .idVendor = 0x05a9,
+ .idProduct = 0x264a,
+ .bInterfaceClass = USB_CLASS_VIDEO,
+ .bInterfaceSubClass = 1,
+ .bInterfaceProtocol = 0,
+ .driver_info = UVC_QUIRK_PROBE_DEF },
/* Apple Built-In iSight */
{ .match_flags = USB_DEVICE_ID_MATCH_DEVICE
| USB_DEVICE_ID_MATCH_INT_INFO,
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam
2013-04-15 19:01 [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam Kamal Mostafa
@ 2013-04-16 23:05 ` Laurent Pinchart
2013-04-17 16:38 ` Kamal Mostafa
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2013-04-16 23:05 UTC (permalink / raw)
To: Kamal Mostafa; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
Hi Kamal,
On Monday 15 April 2013 12:01:51 Kamal Mostafa wrote:
> BugLink: https://bugs.launchpad.net/bugs/1168430
>
> OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the
> same UVC_QUIRK_PROBE_DEF as other OmniVision model to be recognized
> consistently.
>
> Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Thank you for the patch.
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I've taken the patch in my tree and will submit it upstream for v3.11.
Could you please try to get the full 'lsusb -v -d 05a9:264a' output from the
bug reporter ?
> ---
> drivers/media/usb/uvc/uvc_driver.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvc_driver.c
> b/drivers/media/usb/uvc/uvc_driver.c index 5dbefa6..17bd48d 100644
> --- a/drivers/media/usb/uvc/uvc_driver.c
> +++ b/drivers/media/usb/uvc/uvc_driver.c
> @@ -2163,6 +2163,15 @@ static struct usb_device_id uvc_ids[] = {
> .bInterfaceSubClass = 1,
> .bInterfaceProtocol = 0,
> .driver_info = UVC_QUIRK_PROBE_DEF },
> + /* Dell Studio Hybrid 140g (OmniVision webcam) */
> + { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
> + | USB_DEVICE_ID_MATCH_INT_INFO,
> + .idVendor = 0x05a9,
> + .idProduct = 0x264a,
> + .bInterfaceClass = USB_CLASS_VIDEO,
> + .bInterfaceSubClass = 1,
> + .bInterfaceProtocol = 0,
> + .driver_info = UVC_QUIRK_PROBE_DEF },
> /* Apple Built-In iSight */
> { .match_flags = USB_DEVICE_ID_MATCH_DEVICE
>
> | USB_DEVICE_ID_MATCH_INT_INFO,
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam
2013-04-16 23:05 ` Laurent Pinchart
@ 2013-04-17 16:38 ` Kamal Mostafa
2013-04-21 23:11 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Kamal Mostafa @ 2013-04-17 16:38 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 856 bytes --]
On Wed, 2013-04-17 at 01:05 +0200, Laurent Pinchart wrote:
> Hi Kamal,
>
> On Monday 15 April 2013 12:01:51 Kamal Mostafa wrote:
> > BugLink: https://bugs.launchpad.net/bugs/1168430
> >
> > OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the
> > same UVC_QUIRK_PROBE_DEF as other OmniVision model to be recognized
> > consistently.
> >
> > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
>
> Thank you for the patch.
>
> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> I've taken the patch in my tree and will submit it upstream for v3.11.
>
> Could you please try to get the full 'lsusb -v -d 05a9:264a' output from the
> bug reporter ?
Thanks Laurent. The requested lsusb dump is now available at
https://launchpadlibrarian.net/137633994/lsusb-omnivision-264a.txt
-Kamal
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam
2013-04-17 16:38 ` Kamal Mostafa
@ 2013-04-21 23:11 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2013-04-21 23:11 UTC (permalink / raw)
To: Kamal Mostafa; +Cc: linux-media, linux-kernel, Mauro Carvalho Chehab
[-- Attachment #1: Type: text/plain, Size: 995 bytes --]
Hi Kamal,
On Wednesday 17 April 2013 09:38:43 Kamal Mostafa wrote:
> On Wed, 2013-04-17 at 01:05 +0200, Laurent Pinchart wrote:
> > Hi Kamal,
> >
> > On Monday 15 April 2013 12:01:51 Kamal Mostafa wrote:
> > > BugLink: https://bugs.launchpad.net/bugs/1168430
> > >
> > > OminiVision webcam 0x05a9:0x264a (in Dell Studio Hybrid 140g) needs the
> > > same UVC_QUIRK_PROBE_DEF as other OmniVision model to be recognized
> > > consistently.
> > >
> > > Signed-off-by: Kamal Mostafa <kamal@canonical.com>
> >
> > Thank you for the patch.
> >
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> >
> > I've taken the patch in my tree and will submit it upstream for v3.11.
> >
> > Could you please try to get the full 'lsusb -v -d 05a9:264a' output from
> > the bug reporter ?
>
> Thanks Laurent. The requested lsusb dump is now available at
> https://launchpadlibrarian.net/137633994/lsusb-omnivision-264a.txt
Thank you for the information.
--
Regards,
Laurent Pinchart
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-04-21 23:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-04-15 19:01 [PATCH] [media] uvcvideo: quirk PROBE_DEF for Dell Studio / OmniVision webcam Kamal Mostafa
2013-04-16 23:05 ` Laurent Pinchart
2013-04-17 16:38 ` Kamal Mostafa
2013-04-21 23:11 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).