From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailout1.samsung.com ([203.254.224.24]:40280 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbcLORqi (ORCPT ); Thu, 15 Dec 2016 12:46:38 -0500 Subject: Re: [PATCH RFC] [media] s5k6aa: set usleep_range greater 0 To: Nicholas Mc Guire References: <1481594282-12801-1-git-send-email-hofrat@osadl.org> <5277658.1FioEDcST1@avalon> <20161215011405.GB22190@osadl.at> Cc: Laurent Pinchart , Nicholas Mc Guire , Mauro Carvalho Chehab , Sakari Ailus , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org From: Sylwester Nawrocki Message-id: <32517dbe-f893-fb7e-e3e2-dca7f6ca5e7f@samsung.com> Date: Thu, 15 Dec 2016 18:45:54 +0100 MIME-version: 1.0 In-reply-to: <20161215011405.GB22190@osadl.at> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: On 12/15/2016 02:14 AM, Nicholas Mc Guire wrote: > if its actually unused then it might be best to completely drop the code > raher than fixing up dead-code. Is the EXYNOS the only system that had > this device in use ? If it shold stay in then setting it to the above > proposed 3000, 4000 would seem the most resonable to me as I asume this > change would stay untested. I agree, there little sense in modifying unused code which cannot be tested anyway. The whole driver is a candidate for removal as it has no users in mainline. AFAIK it had only been used on Exynos platforms. I'd suggest to just drop the delay call, there are already usleep_range() calls after the GPIO state change. IIRC the delay was needed to ensure proper I2C bus operation after enabling the voltage level translator, but I'm not 100% sure. -- Thanks, Sylwester