Re: [PATCH v2 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT

Laurent Pinchart
2013-10-02T23:29:30Z

Hi Sakari,

Thank you for the patch.

On Thursday 03 October 2013 02:17:50 Sakari Ailus wrote:
> Pads that set this flag must be connected by an active link for the entity
> to stream.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> Acked-by: Sylwester Nawrocki <sylvester.nawrocki@gmail.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> Documentation/DocBook/media/v4l/media-ioc-enum-links.xml | 10 ++++++++++
> include/uapi/linux/media.h | 1 +
> 2 files changed, 11 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml index
> 355df43..e357dc9 100644
> --- a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> +++ b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> @@ -134,6 +134,16 @@
> <entry>Output pad, relative to the entity. Output pads source data
> and are origins of links.</entry>
> </row>
> + <row>
> + <entry><constant>MEDIA_PAD_FL_MUST_CONNECT</constant></entry>
> + <entry>If this flag is set and the pad is linked to any other
> + pad, then at least one of those links must be enabled for the
> + entity to be able to stream. There could be temporary reasons
> + (e.g. device configuration dependent) for the pad to need
> + enabled links even when this flag isn't set; the absence of the
> + flag doesn't imply there is none. The flag has no effect on pads
> + without connected links.</entry>
> + </row>
>
> </tgroup>
>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index ed49574..d847c76 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -98,6 +98,7 @@ struct media_entity_desc {
>
> #define MEDIA_PAD_FL_SINK (1 << 0)
> #define MEDIA_PAD_FL_SOURCE (1 << 1)
> +#define MEDIA_PAD_FL_MUST_CONNECT (1 << 2)
>
> struct media_pad_desc {
> __u32 entity; /* entity ID */
--
Regards,

Laurent Pinchart