Re: [PATCH v2 1/8] dt-bindings: media: Add nxp neoisp support

[Antoine Bouyer <antoine.bouyer@nxp.com>]

On 5/11/26 6:26 PM, Conor Dooley wrote:
> On Mon, May 11, 2026 at 03:26:21PM +0200, Antoine Bouyer wrote:
>> Add the yaml binding for NXP's Neo Image Signal Processor (ISP).
>>
>> Signed-off-by: Antoine Bouyer <antoine.bouyer@nxp.com>
>> ---
>>   .../bindings/media/nxp,imx95-neoisp.yaml      | 62 +++++++++++++++++++
>>   1 file changed, 62 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/media/nxp,imx95-neoisp.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/media/nxp,imx95-neoisp.yaml b/Documentation/devicetree/bindings/media/nxp,imx95-neoisp.yaml
>> new file mode 100644
>> index 000000000000..458c4e4d640d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/media/nxp,imx95-neoisp.yaml
>> @@ -0,0 +1,62 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/media/nxp,imx95-neoisp.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: NXP NEOISP Image Signal Processing Pipeline
>> +
>> +maintainers:
>> +  - Antoine Bouyer <antoine.bouyer@nxp.com>
>> +
>> +description:
>> +  The NXP NEOISP performs a set of image processing tasks on the RAW camera
>> +  stream and provides RGB or YUV enhanced image.
> 
> Can someone explain to me please why there are no ports properties to
> represent the attached camera/other elements of the pipeline?
> 
> This is not a review comment per se, this is me not understanding what
> the delimitation is.

Hi Conor,

The neoisp doesn't have any port indeed. It creates a subdevice, with 
its own video devices (x6), and it runs in M2M mode.

Userspace copies RAW buffer captured from sensor(s) into neoisp video 
device(s), and let it decode and generate an YUV/RGB image depending on 
the config. The decoded image is copied from neoisp capture video device(s).

Same approach is used in pispbe driver for instance.

BR
Antoine

> 
> 
> Cheers,
> Conor.
> 
>> +
>> +properties:
>> +  compatible:
>> +    enum:
>> +      - nxp,imx95-neoisp
>> +
>> +  reg:
>> +    items:
>> +      - description: The configuration registers
>> +      - description: ISP local memories
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    maxItems: 1
>> +
>> +  clock-names:
>> +    items:
>> +      - const: camcm0
>> +
>> +  power-domains:
>> +    maxItems: 1
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - clock-names
>> +  - power-domains
>> +
>> +additionalProperties: false
>> +
>> +examples:
>> +  - |
>> +    #include <dt-bindings/interrupt-controller/arm-gic.h>
>> +
>> +    isp@4ae00000 {
>> +        compatible = "nxp,imx95-neoisp";
>> +        reg = <0x4ae00000 0x8000>,
>> +              <0x4afe0000 0x10000>;
>> +        interrupts = <GIC_SPI 222 IRQ_TYPE_LEVEL_HIGH>;
>> +        interrupt-parent = <&gic>;
>> +        clocks = <&scmi_clk 64>; /* IMX95_CLK_CAMCM0 */
>> +        clock-names = "camcm0";
>> +        power-domains = <&scmi_devpd 3>; /* IMX95_PD_CAMERA */
>> +    };
>> -- 
>> 2.51.0
>>