[PATCH 1/2] media: meye: relax dependencies if COMPILE_TEST

[PATCH 1/2] media: meye: relax dependencies if COMPILE_TEST

[Mauro Carvalho Chehab]

This driver can be built successfuly on non-x86 archs, if
we remove SONY_LAPTOP dependency.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/media/pci/meye/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/media/pci/meye/Kconfig b/drivers/media/pci/meye/Kconfig
index b4bf848be5a0..2e60334ffef5 100644
--- a/drivers/media/pci/meye/Kconfig
+++ b/drivers/media/pci/meye/Kconfig
@@ -1,6 +1,7 @@
 config VIDEO_MEYE
 	tristate "Sony Vaio Picturebook Motion Eye Video For Linux"
-	depends on PCI && SONY_LAPTOP && VIDEO_V4L2
+	depends on PCI && VIDEO_V4L2
+	depends on SONY_LAPTOP || COMPILE_TEST
 	---help---
 	  This is the video4linux driver for the Motion Eye camera found
 	  in the Vaio Picturebook laptops. Please read the material in
-- 
2.14.3

[PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Mauro Carvalho Chehab]

The dependency of DRM_OMAP = n can be relaxed for just
compilation test.

This allows building the omap3isp driver with allyesconfig
on ARM.

Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
---
 drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig b/drivers/video/fbdev/omap2/omapfb/Kconfig
index e6226aeed17e..e42794a5e26c 100644
--- a/drivers/video/fbdev/omap2/omapfb/Kconfig
+++ b/drivers/video/fbdev/omap2/omapfb/Kconfig
@@ -4,7 +4,7 @@ config OMAP2_VRFB
 menuconfig FB_OMAP2
         tristate "OMAP2+ frame buffer support"
         depends on FB
-        depends on DRM_OMAP = n
+        depends on DRM_OMAP = n || COMPILE_TEST
 
         select FB_OMAP2_DSS
 	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3
-- 
2.14.3

Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Laurent Pinchart]

Hi Mauro,

Thank you for the patch.

On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote:
> The dependency of DRM_OMAP = n can be relaxed for just
> compilation test.
> 
> This allows building the omap3isp driver with allyesconfig
> on ARM.

omapfb has nothing to do with omap3isp. I assume you meant omap_vout.

There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same 
time, they export identical symbols. I believe you will end up with link 
failures if you do so.

> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
> ---
>  drivers/video/fbdev/omap2/omapfb/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/video/fbdev/omap2/omapfb/Kconfig
> b/drivers/video/fbdev/omap2/omapfb/Kconfig index e6226aeed17e..e42794a5e26c
> 100644
> --- a/drivers/video/fbdev/omap2/omapfb/Kconfig
> +++ b/drivers/video/fbdev/omap2/omapfb/Kconfig
> @@ -4,7 +4,7 @@ config OMAP2_VRFB
>  menuconfig FB_OMAP2
>          tristate "OMAP2+ frame buffer support"
>          depends on FB
> -        depends on DRM_OMAP = n
> +        depends on DRM_OMAP = n || COMPILE_TEST
> 
>          select FB_OMAP2_DSS
>  	select OMAP2_VRFB if ARCH_OMAP2 || ARCH_OMAP3

-- 
Regards,

Laurent Pinchart

Re: [PATCH 2/2] media: omapfb: relax compilation if COMPILE_TEST

[Mauro Carvalho Chehab]

Em Sat, 07 Apr 2018 14:46:56 +0300
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:

> Hi Mauro,
> 
> Thank you for the patch.
> 
> On Friday, 6 April 2018 18:33:20 EEST Mauro Carvalho Chehab wrote:
> > The dependency of DRM_OMAP = n can be relaxed for just
> > compilation test.
> > 
> > This allows building the omap3isp driver with allyesconfig
> > on ARM.  
> 
> omapfb has nothing to do with omap3isp. I assume you meant omap_vout.
> 
> There's a reason why both DRM_OMAP and FB_OMAP2 can't be compiled at the same 
> time, they export identical symbols. I believe you will end up with link 
> failures if you do so.

Ah, OK. I'll just drop this patch.

Thanks,
Mauro

Re: [PATCH 1/2] media: meye: relax dependencies if COMPILE_TEST

[kbuild test robot]

[-- Attachment #1: Type: text/plain, Size: 1259 bytes --]

Hi Mauro,

I love your patch! Yet something to improve:

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/media-meye-relax-dependencies-if-COMPILE_TEST/20180407-073023
base:   git://linuxtv.org/media_tree.git master
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=ia64 

All errors (new ones prefixed by >>):

   ERROR: "ia64_delay_loop" [drivers/spi/spi-thunderx.ko] undefined!
   ERROR: "__sw_hweight8" [drivers/net/wireless/mediatek/mt76/mt76.ko] undefined!
   ERROR: "ia64_delay_loop" [drivers/net/phy/mdio-cavium.ko] undefined!
>> ERROR: "sony_pic_camera_command" [drivers/media/pci/meye/meye.ko] undefined!

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 49584 bytes --]