* [PATCH] staging: omap4iss: copy paste error in iss_get_clocks
@ 2014-06-05 7:07 Vitaly Osipov
2014-06-06 14:01 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Vitaly Osipov @ 2014-06-05 7:07 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Greg Kroah-Hartman, Sergio Aguirre,
linux-media, devel
It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The
current code looks like an oversight in pasting the block just above
this one.
Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
---
drivers/staging/media/omap4iss/iss.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/omap4iss/iss.c b/drivers/staging/media/omap4iss/iss.c
index 2e422dd..4a9e444 100644
--- a/drivers/staging/media/omap4iss/iss.c
+++ b/drivers/staging/media/omap4iss/iss.c
@@ -1029,7 +1029,7 @@ static int iss_get_clocks(struct iss_device *iss)
if (IS_ERR(iss->iss_ctrlclk)) {
dev_err(iss->dev, "Unable to get iss_ctrlclk clock info\n");
iss_put_clocks(iss);
- return PTR_ERR(iss->iss_fck);
+ return PTR_ERR(iss->iss_ctrlclk);
}
return 0;
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: omap4iss: copy paste error in iss_get_clocks
2014-06-05 7:07 [PATCH] staging: omap4iss: copy paste error in iss_get_clocks Vitaly Osipov
@ 2014-06-06 14:01 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2014-06-06 14:01 UTC (permalink / raw)
To: Vitaly Osipov
Cc: Mauro Carvalho Chehab, Greg Kroah-Hartman, Sergio Aguirre,
linux-media, devel
Hi Vitaly,
Thank you for the patch.
On Thursday 05 June 2014 17:07:48 Vitaly Osipov wrote:
> It makes more sense to return PTR_ERR(iss->iss_ctrlclk) here. The
> current code looks like an oversight in pasting the block just above
> this one.
>
> Signed-off-by: Vitaly Osipov <vitaly.osipov@gmail.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/staging/media/omap4iss/iss.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/media/omap4iss/iss.c
> b/drivers/staging/media/omap4iss/iss.c index 2e422dd..4a9e444 100644
> --- a/drivers/staging/media/omap4iss/iss.c
> +++ b/drivers/staging/media/omap4iss/iss.c
> @@ -1029,7 +1029,7 @@ static int iss_get_clocks(struct iss_device *iss)
> if (IS_ERR(iss->iss_ctrlclk)) {
> dev_err(iss->dev, "Unable to get iss_ctrlclk clock info\n");
> iss_put_clocks(iss);
> - return PTR_ERR(iss->iss_fck);
> + return PTR_ERR(iss->iss_ctrlclk);
> }
>
> return 0;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-06-06 14:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-06-05 7:07 [PATCH] staging: omap4iss: copy paste error in iss_get_clocks Vitaly Osipov
2014-06-06 14:01 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox