From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:38813 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751081AbbKWQla (ORCPT ); Mon, 23 Nov 2015 11:41:30 -0500 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: Linux Media Mailing List , Hans Verkuil , Sakari Ailus Subject: Re: [PATCH 1/2] [media] media_entity: remove gfp_flags argument Date: Mon, 23 Nov 2015 18:41:37 +0200 Message-ID: <3372556.3faHDQeKTD@avalon> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, Thank you for the patch. On Wednesday 09 September 2015 08:32:02 Mauro Carvalho Chehab wrote: > We should not be creating device nodes at IRQ contexts. So, > the only flags we'll be using will be GFP_KERNEL. Let's > remove the gfp_flags, in order to make the interface simpler. > > If we ever need it, it would be easy to revert those changes. > > While here, remove an extra blank line. > > Suggested-by: Sakari Ailus > Signed-off-by: Mauro Carvalho Chehab > > diff --git a/drivers/media/dvb-core/dvbdev.c > b/drivers/media/dvb-core/dvbdev.c index e9f24c1479dd..60828a9537a0 100644 > --- a/drivers/media/dvb-core/dvbdev.c > +++ b/drivers/media/dvb-core/dvbdev.c > @@ -379,8 +379,7 @@ static int dvb_register_media_device(struct dvb_device > *dvbdev, > > dvbdev->intf_devnode = media_devnode_create(dvbdev->adapter->mdev, > intf_type, 0, > - DVB_MAJOR, minor, > - GFP_KERNEL); > + DVB_MAJOR, minor); > > if (!dvbdev->intf_devnode) > return -ENOMEM; > diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c > index 4868b8269204..f28265864b76 100644 > --- a/drivers/media/media-entity.c > +++ b/drivers/media/media-entity.c > @@ -887,12 +887,11 @@ static void media_interface_init(struct media_device > *mdev, > > struct media_intf_devnode *media_devnode_create(struct media_device *mdev, > u32 type, u32 flags, > - u32 major, u32 minor, > - gfp_t gfp_flags) > + u32 major, u32 minor) > { > struct media_intf_devnode *devnode; > > - devnode = kzalloc(sizeof(*devnode), gfp_flags); > + devnode = kzalloc(sizeof(*devnode), GFP_KERNEL); > if (!devnode) > return NULL; > > diff --git a/drivers/media/v4l2-core/v4l2-dev.c > b/drivers/media/v4l2-core/v4l2-dev.c index 430aa2330d07..982255d2063f > 100644 > --- a/drivers/media/v4l2-core/v4l2-dev.c > +++ b/drivers/media/v4l2-core/v4l2-dev.c > @@ -777,8 +777,7 @@ static int video_register_media_controller(struct > video_device *vdev, int type) vdev->intf_devnode = > media_devnode_create(vdev->v4l2_dev->mdev, > intf_type, > 0, VIDEO_MAJOR, > - vdev->minor, > - GFP_KERNEL); > + vdev->minor); > if (!vdev->intf_devnode) { > media_device_unregister_entity(&vdev->entity); > return -ENOMEM; > diff --git a/include/media/media-entity.h b/include/media/media-entity.h > index 9cbb10079024..44ab153c37fc 100644 > --- a/include/media/media-entity.h > +++ b/include/media/media-entity.h > @@ -71,7 +71,6 @@ struct media_gobj { > struct list_head list; > }; > > - This belongs to "media: add a common struct to be embed on media graph objects". I know that you're reluctant to rebase, split and squash patches from fear of introducing breakages, but white space fixes should be really harmless :-) The rest of the patch looks good to me, but as mentioned over IRC, I still think it would be beneficial to do a final round of rebase, split and squash as otherwise it's pretty difficult to perform a final review and ensure everything is right. This patch looks like a pretty safe candidate in that regard. > struct media_pipeline { > }; > > @@ -373,8 +372,7 @@ void media_entity_pipeline_stop(struct media_entity > *entity); struct media_intf_devnode * > __must_check media_devnode_create(struct media_device *mdev, > u32 type, u32 flags, > - u32 major, u32 minor, > - gfp_t gfp_flags); > + u32 major, u32 minor); > void media_devnode_remove(struct media_intf_devnode *devnode); > struct media_link * > __must_check media_create_intf_link(struct media_entity *entity, -- Regards, Laurent Pinchart