From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:37957 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751476AbdISL4U (ORCPT ); Tue, 19 Sep 2017 07:56:20 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se, maxime.ripard@free-electrons.com, robh@kernel.org, hverkuil@xs4all.nl, devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org Subject: Re: [PATCH v13 09/25] omap3isp: Print the name of the entity where no source pads could be found Date: Tue, 19 Sep 2017 14:56:24 +0300 Message-ID: <3405875.r0PdsRIrir@avalon> In-Reply-To: <20170915141724.23124-10-sakari.ailus@linux.intel.com> References: <20170915141724.23124-1-sakari.ailus@linux.intel.com> <20170915141724.23124-10-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:08 EEST Sakari Ailus wrote: > If no source pads are found in an entity, print the name of the entity. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/omap3isp/isp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index 3b1a9cd0e591..9a694924e46e > 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -1669,8 +1669,8 @@ static int isp_link_entity( > break; > } > if (i == entity->num_pads) { > - dev_err(isp->dev, "%s: no source pad in external entity\n", > - __func__); > + dev_err(isp->dev, "%s: no source pad in external entity %s\n", > + __func__, entity->name); > return -EINVAL; > } -- Regards, Laurent Pinchart