From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [PATCH 0/2] v4l-utils: Add missing v4l2-mediabus.h header
Date: Tue, 03 Jun 2014 12:40:59 +0200 [thread overview]
Message-ID: <3433266.HJNPOlTexz@avalon> (raw)
In-Reply-To: <538D99DE.8040602@xs4all.nl>
Hi Hans,
On Tuesday 03 June 2014 11:48:14 Hans Verkuil wrote:
> On 06/03/14 11:46, Laurent Pinchart wrote:
> > On Tuesday 03 June 2014 08:52:29 Hans Verkuil wrote:
> >> On 06/03/2014 02:44 AM, Laurent Pinchart wrote:
> >>> Hello,
> >>>
> >>> This patch set adds the missing v4l2-mediabus.h header, required by
> >>> media-ctl. Please see individual patches for details, they're pretty
> >>> straightforward.
> >>
> >> Nack.
> >>
> >> The kernel headers used in v4l-utils are installed via 'make
> >> sync-with-kernel'. So these headers shouldn't be edited, instead
> >> Makefile.am should be updated. In particular, that's where the missing
> >> header should be added.
> >
> > I had seen mentions of sync-with-kernel and for some reason thought it was
> > a script. As I couldn't find it in the repository I decided to sync the
> > headers manually :-/
> >
> > Thanks for fixing the problem. By the way, what would you think about
> > modifying sync-with-kernel to use installed kernel headers ?
>
> Patches are welcome!
>
> :-)
Patch sent :-)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2014-06-03 10:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-03 0:44 [PATCH 0/2] v4l-utils: Add missing v4l2-mediabus.h header Laurent Pinchart
2014-06-03 0:44 ` [PATCH 1/2] Use installed kernel headers instead of raw kernel headers Laurent Pinchart
2014-06-03 0:44 ` [PATCH 2/2] Add the missing v4l2-mediabus.h kernel header Laurent Pinchart
2014-06-03 6:52 ` [PATCH 0/2] v4l-utils: Add missing v4l2-mediabus.h header Hans Verkuil
2014-06-03 9:46 ` Laurent Pinchart
2014-06-03 9:48 ` Hans Verkuil
2014-06-03 10:40 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3433266.HJNPOlTexz@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hans.verkuil@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox