From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:37945 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751564AbdISLzi (ORCPT ); Tue, 19 Sep 2017 07:55:38 -0400 From: Laurent Pinchart To: Sakari Ailus Cc: linux-media@vger.kernel.org, niklas.soderlund@ragnatech.se, maxime.ripard@free-electrons.com, robh@kernel.org, hverkuil@xs4all.nl, devicetree@vger.kernel.org, pavel@ucw.cz, sre@kernel.org Subject: Re: [PATCH v13 08/25] omap3isp: Fix check for our own sub-devices Date: Tue, 19 Sep 2017 14:55:43 +0300 Message-ID: <3444678.JLWYLn9vNP@avalon> In-Reply-To: <20170915141724.23124-9-sakari.ailus@linux.intel.com> References: <20170915141724.23124-1-sakari.ailus@linux.intel.com> <20170915141724.23124-9-sakari.ailus@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sakari, Thank you for the patch. On Friday, 15 September 2017 17:17:07 EEST Sakari Ailus wrote: > We only want to link sub-devices that were bound to the async notifier the > isp driver registered but there may be other sub-devices in the > v4l2_device as well. Check for the correct async notifier. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil > Acked-by: Pavel Machek Reviewed-by: Laurent Pinchart > --- > drivers/media/platform/omap3isp/isp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/omap3isp/isp.c > b/drivers/media/platform/omap3isp/isp.c index a546cf774d40..3b1a9cd0e591 > 100644 > --- a/drivers/media/platform/omap3isp/isp.c > +++ b/drivers/media/platform/omap3isp/isp.c > @@ -2155,7 +2155,7 @@ static int isp_subdev_notifier_complete(struct > v4l2_async_notifier *async) return ret; > > list_for_each_entry(sd, &v4l2_dev->subdevs, list) { > - if (!sd->asd) > + if (sd->notifier != &isp->notifier) > continue; > > ret = isp_link_entity(isp, &sd->entity, -- Regards, Laurent Pinchart