From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 03/13] v4l: vsp1: Implement runtime PM support
Date: Mon, 25 Apr 2016 16:33:42 +0300 [thread overview]
Message-ID: <3495523.9cqiUnevx8@avalon> (raw)
In-Reply-To: <CAMuHMdV9WKVCm_9Yj3FhkGQyvKaz2QorjZd=X1wFcb80bJhsoA@mail.gmail.com>
Hi Geert,
Thank you for the review.
On Monday 25 Apr 2016 10:24:22 Geert Uytterhoeven wrote:
> On Sun, Apr 24, 2016 at 1:49 AM, Laurent Pinchart
>
> <laurent.pinchart+renesas@ideasonboard.com> wrote:
> > Replace the manual refcount and clock management code by runtime PM.
> >
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >
> > drivers/media/platform/Kconfig | 1 +
> > drivers/media/platform/vsp1/vsp1.h | 3 -
> > drivers/media/platform/vsp1/vsp1_drv.c | 101 ++++++++++++---------------
> > drivers/media/platform/vsp1/vsp1_pipe.c | 2 +-
> > 4 files changed, 54 insertions(+), 53 deletions(-)
> >
> > diff --git a/drivers/media/platform/Kconfig
> > b/drivers/media/platform/Kconfig index f453910050be..28d0db102c0b 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -264,6 +264,7 @@ config VIDEO_RENESAS_VSP1
> > tristate "Renesas VSP1 Video Processing Engine"
> > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> > depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> > + depends on PM
>
> PM is always enabled since commits 2ee98234b88174f2 ("arm64: renesas: Enable
> PM and PM_GENERIC_DOMAINS for SoCs with PM Domains") and 71d076ceb245f0d9
> ("ARM: shmobile: Enable PM and PM_GENERIC_DOMAINS for SoCs with PM
> Domains").
>
> Even before that, drivers/sh/pm_runtime.c would have taken care of
> enabling the clocks for you.
OK, I'll fix that. COMPILE_TEST should be handled by the pm_runtime.h stub
functions.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-04-25 13:33 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-23 23:49 [PATCH 00/13] R-Car VSP improvements for v4.7 - Round 2 Laurent Pinchart
2016-04-23 23:49 ` [PATCH 01/13] dt-bindings: Add Renesas R-Car FCP DT bindings Laurent Pinchart
2016-04-25 7:32 ` Geert Uytterhoeven
2016-04-25 13:27 ` Laurent Pinchart
2016-04-23 23:49 ` [PATCH 02/13] v4l: Add Renesas R-Car FCP driver Laurent Pinchart
2016-04-25 7:37 ` Geert Uytterhoeven
2016-04-25 14:00 ` Laurent Pinchart
2016-04-23 23:49 ` [PATCH 03/13] v4l: vsp1: Implement runtime PM support Laurent Pinchart
2016-04-25 8:24 ` Geert Uytterhoeven
2016-04-25 13:33 ` Laurent Pinchart [this message]
2016-04-23 23:49 ` [PATCH 04/13] v4l: vsp1: Don't handle clocks manually Laurent Pinchart
2016-04-23 23:49 ` [PATCH 05/13] v4l: vsp1: Add FCP support Laurent Pinchart
2016-04-23 23:49 ` [PATCH 06/13] v4l: vsp1: Add output node value to routing table Laurent Pinchart
2016-04-23 23:49 ` [PATCH 07/13] v4l: vsp1: Replace container_of() with dedicated macro Laurent Pinchart
2016-04-23 23:49 ` [PATCH 08/13] v4l: vsp1: Make vsp1_entity_get_pad_compose() more generic Laurent Pinchart
2016-04-23 23:49 ` [PATCH 09/13] v4l: vsp1: Move frame sequence number from video node to pipeline Laurent Pinchart
2016-04-23 23:49 ` [PATCH 10/13] v4l: vsp1: Group DRM RPF parameters in a structure Laurent Pinchart
2016-04-23 23:49 ` [PATCH 11/13] drm: rcar-du: Add alpha support for VSP planes Laurent Pinchart
2016-04-23 23:49 ` [PATCH 12/13] drm: rcar-du: Add Z-order " Laurent Pinchart
2016-04-23 23:50 ` [PATCH 13/13] v4l: vsp1: Remove deprecated DRM API Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3495523.9cqiUnevx8@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=geert@linux-m68k.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox