public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomasz Stanislawski <t.stanislaws@samsung.com>
Cc: linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org,
	airlied@redhat.com, m.szyprowski@samsung.com,
	kyungmin.park@samsung.com, sumit.semwal@ti.com,
	daeinki@gmail.com, daniel.vetter@ffwll.ch, robdclark@gmail.com,
	pawel@osciak.com, linaro-mm-sig@lists.linaro.org,
	hverkuil@xs4all.nl, remi@remlab.net, subashrp@gmail.com,
	mchehab@redhat.com, g.liakhovetski@gmx.de,
	linux-doc@vger.kernel.org
Subject: Re: [PATCHv6 02/13] Documentation: media: description of DMABUF importing in V4L2
Date: Mon, 28 May 2012 23:30:05 +0200	[thread overview]
Message-ID: <3552222.dzY4fiG81O@avalon> (raw)
In-Reply-To: <1337775027-9489-3-git-send-email-t.stanislaws@samsung.com>

Hi Tomasz,

Thanks for the patch.


On Wednesday 23 May 2012 14:10:16 Tomasz Stanislawski wrote:
> This patch adds description and usage examples for importing
> DMABUF file descriptor in V4L2.
> 
> Signed-off-by: Tomasz Stanislawski <t.stanislaws@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> CC: linux-doc@vger.kernel.org

[snip]

> @@ -103,6 +105,7 @@ as the &v4l2-format; <structfield>type</structfield>
> field. See <xref <entry><structfield>memory</structfield></entry>
>  	    <entry>Applications set this field to
>  <constant>V4L2_MEMORY_MMAP</constant> or
> +<constant>V4L2_MEMORY_DMABUF</constant> or
>  <constant>V4L2_MEMORY_USERPTR</constant>. See <xref linkend="v4l2-memory"
>  />.</entry>
>  	  </row>

If you resubmit to fix the compat-ioctl issue in 01/13, could you please 
replace this with

<entry>Applications set this field to
<constant>V4L2_MEMORY_MMAP</constant>,
<constant>V4L2_MEMORY_DMABUF</constant> or
<constant>V4L2_MEMORY_USERPTR</constant>. See <xref linkend="v4l2-memory"/>.
</entry>

like in v5 ?

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2012-05-28 21:29 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-23 12:10 [PATCHv6 00/13] Integration of videobuf2 with dmabuf Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 01/13] v4l: Add DMABUF as a memory type Tomasz Stanislawski
2012-05-28 21:12   ` Laurent Pinchart
2012-05-23 12:10 ` [PATCHv6 02/13] Documentation: media: description of DMABUF importing in V4L2 Tomasz Stanislawski
2012-05-28 21:30   ` Laurent Pinchart [this message]
2012-05-23 12:10 ` [PATCHv6 03/13] v4l: vb2: add support for shared buffer (dma_buf) Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 04/13] v4l: vb: remove warnings about MEMORY_DMABUF Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 05/13] v4l: vb2-dma-contig: Shorten vb2_dma_contig prefix to vb2_dc Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 06/13] v4l: vb2-dma-contig: Remove unneeded allocation context structure Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 07/13] v4l: vb2-dma-contig: Reorder functions Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 08/13] v4l: vb2-dma-contig: add support for scatterlist in userptr mode Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 09/13] v4l: vb2: add prepare/finish callbacks to allocators Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 10/13] v4l: vb2-dma-contig: add prepare/finish to dma-contig allocator Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 11/13] v4l: vb2-dma-contig: add support for dma_buf importing Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 12/13] v4l: s5p-tv: mixer: support for dmabuf importing Tomasz Stanislawski
2012-05-23 12:10 ` [PATCHv6 13/13] v4l: s5p-fimc: " Tomasz Stanislawski
2012-05-28 22:25 ` [PATCHv6 00/13] Integration of videobuf2 with dmabuf Laurent Pinchart
2012-05-30 15:26   ` Semwal, Sumit
2012-06-04 19:34     ` [Linaro-mm-sig] " Rebecca Schultz Zavin
2012-06-04 20:28       ` Rob Clark
2012-06-04 20:46         ` Rebecca Schultz Zavin
2012-06-04 20:56           ` Rebecca Schultz Zavin
2012-06-04 21:04           ` Rob Clark
2012-06-04 21:58       ` Hans Verkuil
2012-06-05  3:36         ` Rebecca Schultz Zavin
2012-06-05  6:37         ` Hans Verkuil
2012-06-06  3:46       ` Laurent Pinchart
2012-06-06  8:17         ` Hans Verkuil
2012-06-07  0:52           ` Laurent Pinchart
2012-06-07  6:43             ` Hans Verkuil
2012-06-07 10:18               ` Sylwester Nawrocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3552222.dzY4fiG81O@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=airlied@redhat.com \
    --cc=daeinki@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=g.liakhovetski@gmx.de \
    --cc=hverkuil@xs4all.nl \
    --cc=kyungmin.park@samsung.com \
    --cc=linaro-mm-sig@lists.linaro.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mchehab@redhat.com \
    --cc=pawel@osciak.com \
    --cc=remi@remlab.net \
    --cc=robdclark@gmail.com \
    --cc=subashrp@gmail.com \
    --cc=sumit.semwal@ti.com \
    --cc=t.stanislaws@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox