From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:45410 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817AbeCFQej (ORCPT ); Tue, 6 Mar 2018 11:34:39 -0500 From: Laurent Pinchart To: Mauro Carvalho Chehab Cc: Geert Uytterhoeven , linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1 Date: Tue, 06 Mar 2018 18:35:32 +0200 Message-ID: <3554226.unskCpdSGX@avalon> In-Reply-To: <20180306132515.261cf47c@vento.lan> References: <1519668550-26082-1-git-send-email-geert+renesas@glider.be> <20180306132515.261cf47c@vento.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Mauro, On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote: > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu: > > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF. > > As ARCH_RENESAS implies OF, the latter can be dropped. > > > > Signed-off-by: Geert Uytterhoeven > > --- > > > > drivers/media/platform/Kconfig | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/media/platform/Kconfig > > b/drivers/media/platform/Kconfig index 614fbef08ddcabb0..2b8b1ad0edd9eb31 > > 100644 > > --- a/drivers/media/platform/Kconfig > > +++ b/drivers/media/platform/Kconfig > > @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP > > > > config VIDEO_RENESAS_VSP1 > > > > tristate "Renesas VSP1 Video Processing Engine" > > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA > > > > - depends on (ARCH_RENESAS && OF) || COMPILE_TEST > > + depends on ARCH_RENESAS || COMPILE_TEST > > That is not correct! > > COMPILE_TEST doesn't depend on OF. With this patch, it will likely > cause build failures with randconfigs. ARCH_RENESAS implies OF, so replacing (ARCH_RENESAS && OF) with ARCH_RENESAS doesn't change anything. The driver can be compiled with COMPILE_TEST and !OF both before and after this patch. > > depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP > > select VIDEOBUF2_DMA_CONTIG > > select VIDEOBUF2_VMALLOC -- Regards, Laurent Pinchart