From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-renesas-soc@vger.kernel.org, linux-media@vger.kernel.org,
corbet@lwn.net, mchehab@kernel.org, sakari.ailus@linux.intel.com,
hans.verkuil@cisco.com
Subject: Re: [PATCHv3 2/2] v4l: vsp1: Add HGT support
Date: Wed, 07 Sep 2016 15:48:19 +0300 [thread overview]
Message-ID: <3579545.u5RR9atB6T@avalon> (raw)
In-Reply-To: <20160907120938.818-3-niklas.soderlund+renesas@ragnatech.se>
Hi Niklas,
Thank you for the patch.
On Wednesday 07 Sep 2016 14:09:38 Niklas Söderlund wrote:
> The HGT is a Histogram Generator Two-Dimensions. It computes a weighted
> frequency histograms for hue and saturation areas over a configurable
> region of the image with optional subsampling.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
However, please note that we might need to upstream HGT support before HGO. To
ease that, I've split the HGO patches in common code and HGO-specific code,
and rebased your patch on top of that. The result is available at
git://linuxtv.org/pinchartl/media.git vsp1/next
There will still be conflicts if we need to reorder the patches, but they
should be easier to handle now.
> ---
> drivers/media/platform/vsp1/Makefile | 2 +-
> drivers/media/platform/vsp1/vsp1.h | 3 +
> drivers/media/platform/vsp1/vsp1_drv.c | 33 ++++-
> drivers/media/platform/vsp1/vsp1_entity.c | 33 +++--
> drivers/media/platform/vsp1/vsp1_entity.h | 1 +
> drivers/media/platform/vsp1/vsp1_hgt.c | 221 +++++++++++++++++++++++++++
> drivers/media/platform/vsp1/vsp1_hgt.h | 42 ++++++
> drivers/media/platform/vsp1/vsp1_pipe.c | 16 +++
> drivers/media/platform/vsp1/vsp1_pipe.h | 2 +
> drivers/media/platform/vsp1/vsp1_regs.h | 9 ++
> drivers/media/platform/vsp1/vsp1_video.c | 10 +-
> 11 files changed, 356 insertions(+), 16 deletions(-)
> create mode 100644 drivers/media/platform/vsp1/vsp1_hgt.c
> create mode 100644 drivers/media/platform/vsp1/vsp1_hgt.h
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2016-09-07 12:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 12:09 [PATCHv3 0/2] v4l: vsp1: Add HGT support Niklas Söderlund
2016-09-07 12:09 ` [PATCHv3 1/2] v4l: Define a pixel format for the R-Car VSP1 2-D histogram engine Niklas Söderlund
2016-09-07 12:09 ` [PATCHv3 2/2] v4l: vsp1: Add HGT support Niklas Söderlund
2016-09-07 12:48 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3579545.u5RR9atB6T@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=corbet@lwn.net \
--cc=hans.verkuil@cisco.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).