Re: [PATCH 2/3] soc-camera/rcar-vin: remove obsolete driver

Laurent Pinchart
2016-08-01T08:37:21Z

Hi Hans,

Thank you for the patch.

On Monday 01 Aug 2016 09:54:24 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
>
> This driver has been replaced by the non-soc-camera rcar-vin driver.
> The soc-camera framework is being deprecated, so drop this older
> rcar-vin driver in favor of the newer version that does not rely on
> this deprecated framework.
>
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

I'm all for removal of dead code :-)

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

But please get Niklas' ack to confirm that the new driver supports all the
feature available in the old one.

> ---
> drivers/media/platform/soc_camera/Kconfig | 10 -
> drivers/media/platform/soc_camera/Makefile | 1 -
> drivers/media/platform/soc_camera/rcar_vin.c | 1970 -----------------------
> 3 files changed, 1981 deletions(-)
> delete mode 100644 drivers/media/platform/soc_camera/rcar_vin.c

--
Regards,

Laurent Pinchart