Re: [PATCH 2/3] soc-camera/rcar-vin: remove obsolete driver

Hans Verkuil
2016-08-02T07:35:45Z

On 08/01/2016 10:41 PM, Niklas Söderlund wrote:
> On 2016-08-01 11:31:11 +0300, Laurent Pinchart wrote:
>> Hi Hans,
>>
>> Thank you for the patch.
>>
>> On Monday 01 Aug 2016 09:54:24 Hans Verkuil wrote:
>>> From: Hans Verkuil <hans.verkuil@cisco.com>
>>>
>>> This driver has been replaced by the non-soc-camera rcar-vin driver.
>>> The soc-camera framework is being deprecated, so drop this older
>>> rcar-vin driver in favor of the newer version that does not rely on
>>> this deprecated framework.
>>>
>>> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
>>> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>> Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>>> Cc: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
>>
>> I'm all for removal of dead code :-)
>>
>> Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>>
>> But please get Niklas' ack to confirm that the new driver supports all the
>> feature available in the old one.
>
> I'm all for removing this code. And I do believe the new driver supports
> (almost, see 1) all features this one do. There are however two known
> issues with the new driver which maybe should be resolved before the old
> one is removed.
>
> 1. The soc-camera driver call g_std to determine video standard if field
> is V4L2_FIELD_INTERLACED. The new driver dose not.
>
> I'm preparing a patch which restores this functionality and hope to
> post it soon.

Shouldn't be a problem to get that in for 4.9.

>
> 2. There is a error in the DT parsing code where of_node_put() is called
> twice resulting in a nice backtrace while booting if the debug config
> options are enabled.
>
> There is a fix for this in the Gen3 enablement series but maybe I
> should break it out from there and post it separately?

Yes please. It sounds as if this should be backported to 4.8-rcX as well?

>
> I would like to solve issue no 1 before we remove the soc-camera driver,
> hopefully we can do so shortly.

The removal of the old driver is for 4.9, so there is a lot of time.

Regards,

Hans