From: Matthias Brugger <matthias.bgg@gmail.com>
To: Hans Verkuil <hverkuil@xs4all.nl>,
Minghsiu Tsai <minghsiu.tsai@mediatek.com>,
Hans Verkuil <hans.verkuil@cisco.com>,
daniel.thompson@linaro.org, Rob Herring <robh+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Daniel Kurtz <djkurtz@chromium.org>,
Pawel Osciak <posciak@chromium.org>,
Houlong Wei <houlong.wei@mediatek.com>
Cc: srv_heupstream@mediatek.com,
Eddie Huang <eddie.huang@mediatek.com>,
Yingjoe Chen <yingjoe.chen@mediatek.com>,
Wu-Cheng Li <wuchengli@google.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org
Subject: Re: [PATCH v4 3/3] media: mtk-mdp: Fix mdp device tree
Date: Wed, 7 Jun 2017 11:13:37 +0200 [thread overview]
Message-ID: <35fb23dd-00e2-e0f1-c3ed-e317883ed007@gmail.com> (raw)
In-Reply-To: <9ca0b2c5-db3d-4794-1431-89f5a093252f@xs4all.nl>
On 07/06/17 11:11, Hans Verkuil wrote:
> On 07/06/17 11:07, Matthias Brugger wrote:
>>
>>
>> On 07/06/17 10:56, Hans Verkuil wrote:
>>> On 07/06/17 10:44, Matthias Brugger wrote:
>>>> Hi Hans, hi Mauro,
>>>>
>>>> On 23/05/17 05:24, Minghsiu Tsai wrote:
>>>>> From: Daniel Kurtz <djkurtz@chromium.org>
>>>>>
>>>>> If the mdp_* nodes are under an mdp sub-node, their corresponding
>>>>> platform device does not automatically get its iommu assigned properly.
>>>>>
>>>>> Fix this by moving the mdp component nodes up a level such that they are
>>>>> siblings of mdp and all other SoC subsystems. This also simplifies the
>>>>> device tree.
>>>>>
>>>>> Although it fixes iommu assignment issue, it also break compatibility
>>>>> with old device tree. So, the patch in driver is needed to iterate over
>>>>> sibling mdp device nodes, not child ones, to keep driver work properly.
>>>>>
>>>>> Signed-off-by: Daniel Kurtz <djkurtz@chromium.org>
>>>>> Signed-off-by: Minghsiu Tsai <minghsiu.tsai@mediatek.com>
>>>>> Signed-off-by: Matthias Brugger <matthias.bgg@gmail.com>
>>>>>
>>>>
>>>> Are you OK to take this patch, or do you have any further comments?
>>>
>>> Nope, it's all good. Queued for 4.13.
>>>
>>
>> Thanks!
>>
>> I queued the other two in v4.12-next/dts64
>
> Media bindings normally go through the media subsystem, but you've taken
> that one as well? I need to know, because then I drop it in my tree.
>
My fault, I'll drop it from my tree. After that I only queued patch 2/3.
Sorry.
Matthias
next prev parent reply other threads:[~2017-06-07 9:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 3:24 [PATCH v4 0/3] Fix mdp device tree Minghsiu Tsai
2017-05-23 3:24 ` [PATCH v4 1/3] dt-bindings: mt8173: " Minghsiu Tsai
2017-05-23 3:24 ` [PATCH v4 2/3] arm64: dts: " Minghsiu Tsai
2017-05-23 3:24 ` [PATCH v4 3/3] media: mtk-mdp: " Minghsiu Tsai
2017-06-07 8:44 ` Matthias Brugger
2017-06-07 8:56 ` Hans Verkuil
2017-06-07 9:07 ` Matthias Brugger
2017-06-07 9:11 ` Hans Verkuil
2017-06-07 9:13 ` Matthias Brugger [this message]
2017-06-07 9:15 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=35fb23dd-00e2-e0f1-c3ed-e317883ed007@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=djkurtz@chromium.org \
--cc=eddie.huang@mediatek.com \
--cc=hans.verkuil@cisco.com \
--cc=houlong.wei@mediatek.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=mchehab@osg.samsung.com \
--cc=minghsiu.tsai@mediatek.com \
--cc=posciak@chromium.org \
--cc=robh+dt@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=wuchengli@google.com \
--cc=yingjoe.chen@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).