Re: [PATCH v2 regression fix for 6.19 0/5] media: ov02c10: h/vflip fixes

[Hans Verkuil <hverkuil+cisco@kernel.org>]

Hi Hans,

On 10/12/2025 12:24, Hans de Goede wrote:
> Hi All,
> 
> Commit 69fe27173396 ("media: ov02c10: Fix default vertical flip") which
> has been merged this merge window is causing various problems for
> laptops with a ov02c10 sensors:
> 
> 1. This changes the vflip default but does not update the bayer-order
>    leading to debayer artifacts and wrong colors
> 
> 2. The ov02c10 driver was originally developed on a XPS 16 9640 which
>    has its sensor upside down. Changing the vflip (and hflip) default
>    values fixes the image being upside down on other laptops, but will
>    cause a regression on Dell XPS models causing the image to be upside
>    down there.
> 
> 3. The mentioned commit only changes vflip, so the image now is upside-up,
>    but it is still mirrored.
> 
> Patches 1-4 of this series fixes these issues. Patch 5 is a follow-up
> cleanup patch.
> 
> Hans Verkuil, can you please queue these up as fixes for 6.19?

It's best to wait until v6.19-rc1 is released, then add these patches
on top and post a PR with subject prefix [GIT FIXES for v6.19].

Either Mauro or myself will pick it up (probably Mauro since I'm about
to go on vacation).

Regards,

	Hans

> 
> Changes in v2:
> - Fix Fixes tags to use the correct commit hash
> - Fix compile error in patch 4/5 when CONFIG_ACPI is not set
> - Add Bryan's Reviewed-by to all patches
> 
> Regards,
> 
> Hans
> 
> 
> Hans de Goede (5):
>   media: ov02c10: Fix bayer-pattern change after default vflip change
>   media: ov02c10: Adjust x-win/y-win when changing flipping to preserve
>     bayer-pattern
>   media: ov02c10: Fix the horizontal flip control
>   media: ipu-bridge: Add DMI quirk for Dell XPS laptops with upside down
>     sensors
>   media: ov02c10: Remove unnecessary hflip and vflip pointers
> 
>  drivers/media/i2c/ov02c10.c          | 28 +++++++++++----------------
>  drivers/media/pci/intel/Kconfig      |  2 +-
>  drivers/media/pci/intel/ipu-bridge.c | 29 ++++++++++++++++++++++++++++
>  3 files changed, 41 insertions(+), 18 deletions(-)
>