public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v2 3/3] rcar-vin: declare which VINs can use a Up Down Scaler (UDS)
Date: Thu, 04 Oct 2018 23:15:38 +0300	[thread overview]
Message-ID: <3830300.X5acWg0Hot@avalon> (raw)
In-Reply-To: <20181004200402.15113-4-niklas.soderlund+renesas@ragnatech.se>

Hi Niklas,

Thank you for the patch.

On Thursday, 4 October 2018 23:04:02 EEST Niklas Söderlund wrote:
> Add information about which VINs on which SoC have access to a UDS
> scaler.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/rcar-vin/rcar-core.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-core.c
> b/drivers/media/platform/rcar-vin/rcar-core.c index
> 01e418c2d4c6792e..337ae8bbe1e0b14c 100644
> --- a/drivers/media/platform/rcar-vin/rcar-core.c
> +++ b/drivers/media/platform/rcar-vin/rcar-core.c
> @@ -919,12 +919,21 @@ static const struct rvin_group_route
> rcar_info_r8a7795_routes[] = { { /* Sentinel */ }
>  };
> 
> +static const struct rvin_group_scaler rcar_info_h3_m3w_m3n_scalers[] = {
> +	{ .vin = 0, .companion = 1 },
> +	{ .vin = 1, .companion = 0 },
> +	{ .vin = 4, .companion = 5 },
> +	{ .vin = 5, .companion = 4 },
> +	{ /* Sentinel */ }
> +};
> +
>  static const struct rvin_info rcar_info_r8a7795 = {
>  	.model = RCAR_GEN3,
>  	.use_mc = true,
>  	.max_width = 4096,
>  	.max_height = 4096,
>  	.routes = rcar_info_r8a7795_routes,
> +	.scalers = rcar_info_h3_m3w_m3n_scalers,
>  };
> 
>  static const struct rvin_group_route rcar_info_r8a7795es1_routes[] = {
> @@ -979,6 +988,7 @@ static const struct rvin_info rcar_info_r8a7795es1 = {
>  	.max_width = 4096,
>  	.max_height = 4096,
>  	.routes = rcar_info_r8a7795es1_routes,
> +	.scalers = rcar_info_h3_m3w_m3n_scalers,
>  };
> 
>  static const struct rvin_group_route rcar_info_r8a7796_routes[] = {
> @@ -1019,6 +1029,7 @@ static const struct rvin_info rcar_info_r8a7796 = {
>  	.max_width = 4096,
>  	.max_height = 4096,
>  	.routes = rcar_info_r8a7796_routes,
> +	.scalers = rcar_info_h3_m3w_m3n_scalers,
>  };
> 
>  static const struct rvin_group_route rcar_info_r8a77965_routes[] = {
> @@ -1063,6 +1074,7 @@ static const struct rvin_info rcar_info_r8a77965 = {
>  	.max_width = 4096,
>  	.max_height = 4096,
>  	.routes = rcar_info_r8a77965_routes,
> +	.scalers = rcar_info_h3_m3w_m3n_scalers,
>  };
> 
>  static const struct rvin_group_route rcar_info_r8a77970_routes[] = {
> @@ -1088,12 +1100,18 @@ static const struct rvin_group_route
> rcar_info_r8a77995_routes[] = { { /* Sentinel */ }
>  };
> 
> +static const struct rvin_group_scaler rcar_info_r8a77995_scalers[] = {
> +	{ .vin = 4, .companion = -1 },
> +	{ /* Sentinel */ }
> +};
> +
>  static const struct rvin_info rcar_info_r8a77995 = {
>  	.model = RCAR_GEN3,
>  	.use_mc = true,
>  	.max_width = 4096,
>  	.max_height = 4096,
>  	.routes = rcar_info_r8a77995_routes,
> +	.scalers = rcar_info_r8a77995_scalers,
>  };
> 
>  static const struct of_device_id rvin_of_id_table[] = {


-- 
Regards,

Laurent Pinchart

      reply	other threads:[~2018-10-05  3:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-04 20:03 [PATCH v2 0/3] rcar-vin: add support for UDS (Up Down Scaler) Niklas Söderlund
2018-10-04 20:04 ` [PATCH v2 1/3] rcar-vin: align width before stream start Niklas Söderlund
2018-10-04 20:11   ` Laurent Pinchart
2018-10-04 20:29     ` Niklas Söderlund
2018-10-04 20:51       ` Laurent Pinchart
2018-10-04 20:04 ` [PATCH v2 2/3] rcar-vin: add support for UDS (Up Down Scaler) Niklas Söderlund
2018-10-04 20:49   ` Laurent Pinchart
2018-10-08 16:23   ` Sakari Ailus
2018-10-04 20:04 ` [PATCH v2 3/3] rcar-vin: declare which VINs can use a Up Down Scaler (UDS) Niklas Söderlund
2018-10-04 20:15   ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3830300.X5acWg0Hot@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=niklas.soderlund+renesas@ragnatech.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox