public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: linux-media@vger.kernel.org, marbugge@cisco.com,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [REVIEWv1 PATCH 4/5] adv*: replace the deprecated v4l2_subdev_edid by v4l2_edid.
Date: Fri, 07 Mar 2014 15:07:39 +0100	[thread overview]
Message-ID: <3832137.6klbEKCG06@avalon> (raw)
In-Reply-To: <1394187679-7345-5-git-send-email-hverkuil@xs4all.nl>

Hi Hans,

Thank you for the patch.

On Friday 07 March 2014 11:21:18 Hans Verkuil wrote:
> From: Hans Verkuil <hans.verkuil@cisco.com>
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/i2c/ad9389b.c | 2 +-
>  drivers/media/i2c/adv7511.c | 2 +-
>  drivers/media/i2c/adv7604.c | 4 ++--
>  drivers/media/i2c/adv7842.c | 4 ++--
>  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/media/i2c/ad9389b.c b/drivers/media/i2c/ad9389b.c
> index 83225d6..1b7ecfd 100644
> --- a/drivers/media/i2c/ad9389b.c
> +++ b/drivers/media/i2c/ad9389b.c
> @@ -573,7 +573,7 @@ static const struct v4l2_subdev_core_ops
> ad9389b_core_ops = {
> 
>  /* ------------------------------ PAD OPS ------------------------------ */
> 
> -static int ad9389b_get_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid) +static int ad9389b_get_edid(struct v4l2_subdev *sd, struct
> v4l2_edid *edid) {
>  	struct ad9389b_state *state = get_ad9389b_state(sd);
> 
> diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c/adv7511.c
> index ee61894..942ca4b 100644
> --- a/drivers/media/i2c/adv7511.c
> +++ b/drivers/media/i2c/adv7511.c
> @@ -597,7 +597,7 @@ static int adv7511_isr(struct v4l2_subdev *sd, u32
> status, bool *handled) return 0;
>  }
> 
> -static int adv7511_get_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid) +static int adv7511_get_edid(struct v4l2_subdev *sd, struct
> v4l2_edid *edid) {
>  	struct adv7511_state *state = get_adv7511_state(sd);
> 
> diff --git a/drivers/media/i2c/adv7604.c b/drivers/media/i2c/adv7604.c
> index 71c8570..98cc540 100644
> --- a/drivers/media/i2c/adv7604.c
> +++ b/drivers/media/i2c/adv7604.c
> @@ -1658,7 +1658,7 @@ static int adv7604_isr(struct v4l2_subdev *sd, u32
> status, bool *handled) return 0;
>  }
> 
> -static int adv7604_get_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid) +static int adv7604_get_edid(struct v4l2_subdev *sd, struct
> v4l2_edid *edid) {
>  	struct adv7604_state *state = to_state(sd);
>  	u8 *data = NULL;
> @@ -1728,7 +1728,7 @@ static int get_edid_spa_location(const u8 *edid)
>  	return -1;
>  }
> 
> -static int adv7604_set_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid) +static int adv7604_set_edid(struct v4l2_subdev *sd, struct
> v4l2_edid *edid) {
>  	struct adv7604_state *state = to_state(sd);
>  	int spa_loc;
> diff --git a/drivers/media/i2c/adv7842.c b/drivers/media/i2c/adv7842.c
> index e04fe3f..4d1e07e 100644
> --- a/drivers/media/i2c/adv7842.c
> +++ b/drivers/media/i2c/adv7842.c
> @@ -2014,7 +2014,7 @@ static int adv7842_isr(struct v4l2_subdev *sd, u32
> status, bool *handled) return 0;
>  }
> 
> -static int adv7842_get_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *edid) +static int adv7842_get_edid(struct v4l2_subdev *sd, struct
> v4l2_edid *edid) {
>  	struct adv7842_state *state = to_state(sd);
>  	u8 *data = NULL;
> @@ -2054,7 +2054,7 @@ static int adv7842_get_edid(struct v4l2_subdev *sd,
> struct v4l2_subdev_edid *edi return 0;
>  }
> 
> -static int adv7842_set_edid(struct v4l2_subdev *sd, struct v4l2_subdev_edid
> *e) +static int adv7842_set_edid(struct v4l2_subdev *sd, struct v4l2_edid
> *e) {
>  	struct adv7842_state *state = to_state(sd);
>  	int err = 0;

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2014-03-07 14:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 10:21 [REVIEWv1 PATCH 0/5] Add G/S_EDID support for video nodes Hans Verkuil
2014-03-07 10:21 ` [REVIEWv1 PATCH 1/5] v4l2-compat-ioctl32: fix wrong VIDIOC_SUBDEV_G/S_EDID32 support Hans Verkuil
2014-03-07 14:04   ` Laurent Pinchart
2014-03-07 10:21 ` [REVIEWv1 PATCH 2/5] v4l2: allow v4l2_subdev_edid to be used with video nodes Hans Verkuil
2014-03-07 14:04   ` Laurent Pinchart
2014-03-07 10:21 ` [REVIEWv1 PATCH 3/5] v4l2: add VIDIOC_G/S_EDID support to the v4l2 core Hans Verkuil
2014-03-07 14:07   ` Laurent Pinchart
2014-03-07 10:21 ` [REVIEWv1 PATCH 4/5] adv*: replace the deprecated v4l2_subdev_edid by v4l2_edid Hans Verkuil
2014-03-07 14:07   ` Laurent Pinchart [this message]
2014-03-07 10:21 ` [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation Hans Verkuil
2014-03-07 14:09   ` Laurent Pinchart
2014-03-07 14:19     ` Hans Verkuil
2014-03-07 14:25       ` Laurent Pinchart
2014-03-07 14:31         ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3832137.6klbEKCG06@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hans.verkuil@cisco.com \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-media@vger.kernel.org \
    --cc=marbugge@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox