From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:49639 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751547AbaI2UlD (ORCPT ); Mon, 29 Sep 2014 16:41:03 -0400 From: Laurent Pinchart To: Boris Brezillon Cc: Thierry Reding , dri-devel@lists.freedesktop.org, David Airlie , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Guennadi Liakhovetski , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/5] video: move mediabus format definition to a more standard place Date: Mon, 29 Sep 2014 23:41:09 +0300 Message-ID: <3849580.CgKEmcV7as@avalon> In-Reply-To: <1411999363-28770-2-git-send-email-boris.brezillon@free-electrons.com> References: <1411999363-28770-1-git-send-email-boris.brezillon@free-electrons.com> <1411999363-28770-2-git-send-email-boris.brezillon@free-electrons.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Boris, Thank you for the patch. On Monday 29 September 2014 16:02:39 Boris Brezillon wrote: > Rename mediabus formats and move the enum into a separate header file so > that it can be used by DRM/KMS subsystem without any reference to the V4L2 > subsystem. > > Old V4L2_MBUS_FMT_ definitions are now macros that points to VIDEO_BUS_FMT_ > definitions. > > Signed-off-by: Boris BREZILLON > Acked-by: Guennadi Liakhovetski > --- > include/uapi/linux/Kbuild | 1 + > include/uapi/linux/v4l2-mediabus.h | 183 +++++++++++++------------------ > include/uapi/linux/video-bus-format.h | 127 +++++++++++++++++++++++ > 3 files changed, 207 insertions(+), 104 deletions(-) > create mode 100644 include/uapi/linux/video-bus-format.h One of the self-inflicted rules in V4L2 is to properly document every new media bus format when adding it to the kernel. The documentation is located in Documentation/DocBook/media/v4l/subdev-formats.xml. If we move the formats to a centralized header (which I believe is a good idea), we should also update the documentation, and possibly its location. I really want to avoid getting undocumented formats merged, and this will happen if we don't make the rule clear and/or don't make the documentation easily accessible. Incidentally, patch 2/5 in this series is missing a documentation update ;-) -- Regards, Laurent Pinchart