From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Guennadi Liakhovetski <guennadi.liakhovetski@intel.com>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH v3 2/4] uvcvideo: (cosmetic) remove a superfluous assignment
Date: Fri, 30 Dec 2016 15:30:37 +0200 [thread overview]
Message-ID: <3876000.H63uYd8Bae@avalon> (raw)
In-Reply-To: <1481541412-1186-3-git-send-email-guennadi.liakhovetski@intel.com>
Hi Guennadi,
Thank you for the patch.
On Monday 12 Dec 2016 12:16:50 Guennadi Liakhovetski wrote:
> From: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
>
> Remove a superfluous assignment to a local variable at the end of a
> function.
>
> Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@intel.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree for v4.11.
> ---
> drivers/media/usb/uvc/uvc_video.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/usb/uvc/uvc_video.c
> b/drivers/media/usb/uvc/uvc_video.c index b5589d5..51b5ae5 100644
> --- a/drivers/media/usb/uvc/uvc_video.c
> +++ b/drivers/media/usb/uvc/uvc_video.c
> @@ -1262,8 +1262,7 @@ static void uvc_video_decode_bulk(struct urb *urb,
> struct uvc_streaming *stream, uvc_video_decode_end(stream, buf,
> stream->bulk.header,
> stream->bulk.payload_size);
> if (buf->state == UVC_BUF_STATE_READY)
> - buf = uvc_queue_next_buffer(&stream->queue,
> - buf);
> + uvc_queue_next_buffer(&stream->queue, buf);
> }
>
> stream->bulk.header_size = 0;
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-12-30 13:30 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 11:16 [PATCH v3 0/4] uvcvideo: metadata device node Guennadi Liakhovetski
2016-12-12 11:16 ` [PATCH v3 1/4] uvcvideo: (cosmetic) add and use an inline function Guennadi Liakhovetski
2016-12-30 13:28 ` Laurent Pinchart
2016-12-30 13:50 ` Guennadi Liakhovetski
2016-12-12 11:16 ` [PATCH v3 2/4] uvcvideo: (cosmetic) remove a superfluous assignment Guennadi Liakhovetski
2016-12-30 13:30 ` Laurent Pinchart [this message]
2016-12-12 11:16 ` [PATCH v3 3/4] uvcvideo: fix a wrong macro Guennadi Liakhovetski
2016-12-30 13:33 ` Laurent Pinchart
2016-12-12 11:16 ` [PATCH v3 4/4] uvcvideo: add a metadata device node Guennadi Liakhovetski
2016-12-12 17:31 ` kbuild test robot
2016-12-12 18:56 ` kbuild test robot
2016-12-12 19:32 ` kbuild test robot
2016-12-30 10:43 ` Guennadi Liakhovetski
2016-12-30 12:32 ` Laurent Pinchart
2016-12-30 13:04 ` Guennadi Liakhovetski
2016-12-30 13:20 ` Laurent Pinchart
2017-01-03 14:55 ` Guennadi Liakhovetski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3876000.H63uYd8Bae@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=g.liakhovetski@gmx.de \
--cc=guennadi.liakhovetski@intel.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).