From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:45722 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753679AbdGUKL5 (ORCPT ); Fri, 21 Jul 2017 06:11:57 -0400 From: Laurent Pinchart To: Hans Verkuil Cc: linux-media@vger.kernel.org, Laurent Pinchart , Sakari Ailus , Sylwester Nawrocki , Hans Verkuil Subject: Re: [PATCH 1/4] media-device: set driver_version in media_device_init Date: Fri, 21 Jul 2017 13:12:04 +0300 Message-ID: <3878230.p4nklYSnFj@avalon> In-Reply-To: <20170721090234.6501-2-hverkuil@xs4all.nl> References: <20170721090234.6501-1-hverkuil@xs4all.nl> <20170721090234.6501-2-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, Thank you for the patch. On Friday 21 Jul 2017 11:02:31 Hans Verkuil wrote: > From: Hans Verkuil > > Set the driver_version to LINUX_VERSION_CODE in the media_device_init > call, just as the other media subsystems do. > > There is no point in doing anything else, since version numbers that > are set by drivers are never, ever updated. LINUX_VERSION_CODE will > be updated, and is also set correctly when backporting the media > subsystem to an older kernel using the media_build system. > > Signed-off-by: Hans Verkuil Wouldn't it be even better to drop the driver_version field completely from struct media_device, as it's now hardcoded ? > --- > drivers/media/media-device.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/media/media-device.c b/drivers/media/media-device.c > index fce91b543c14..2beffe3e3464 100644 > --- a/drivers/media/media-device.c > +++ b/drivers/media/media-device.c > @@ -681,6 +681,7 @@ void media_device_init(struct media_device *mdev) > INIT_LIST_HEAD(&mdev->entity_notify); > mutex_init(&mdev->graph_mutex); > ida_init(&mdev->entity_internal_idx); > + mdev->driver_version = LINUX_VERSION_CODE; > > dev_dbg(mdev->dev, "Media device initialized\n"); > } > @@ -833,8 +834,6 @@ void media_device_pci_init(struct media_device *mdev, > mdev->hw_revision = (pci_dev->subsystem_vendor << 16) > > | pci_dev->subsystem_device; > > - mdev->driver_version = LINUX_VERSION_CODE; > - > media_device_init(mdev); > } > EXPORT_SYMBOL_GPL(media_device_pci_init); > @@ -862,7 +861,6 @@ void __media_device_usb_init(struct media_device *mdev, > strlcpy(mdev->serial, udev->serial, sizeof(mdev->serial)); > usb_make_path(udev, mdev->bus_info, sizeof(mdev->bus_info)); > mdev->hw_revision = le16_to_cpu(udev->descriptor.bcdDevice); > - mdev->driver_version = LINUX_VERSION_CODE; > > media_device_init(mdev); > } -- Regards, Laurent Pinchart