public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
* [GIT PULL FOR v3.13] OMAP4 ISS driver
@ 2013-10-15 16:13 Laurent Pinchart
  2013-10-15 16:35 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2013-10-15 16:13 UTC (permalink / raw)
  To: devel
  Cc: Sergio Aguirre, Sakari Ailus, Hans Verkuil, Dan Carpenter,
	linux-media, Greg Kroah-Hartman

Hello,

Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera 
interface).

The driver has been posted for review on the devel@driverdev.osuosl.org and 
linux-media@vger.kernel.org mailing lists. A couple of review comments were 
received (thanks to the reviewers). I've decided to address them as follow-up 
patches in order to keep the original code, well, original and credit Sergio 
Aguirre for his great work.

I'll work on addressing the comments, cleaning up the code and getting the 
driver out of staging in the next couple of kernel versions.

The following changes since commit 61e6cfa80de5760bbe406f4e815b7739205754d2:

  Linux 3.12-rc5 (2013-10-13 15:41:28 -0700)

are available in the git repository at:

  git://linuxtv.org/pinchartl/media.git omap4iss/next

for you to fetch changes up to 8255f7e6fc15f238c40d1244863433bea0436956:

  v4l: omap4iss: Add support for OMAP4 camera interface - Build system 
(2013-10-15 17:56:15 +0200)

----------------------------------------------------------------
Laurent Pinchart (1):
      v4l: omap4iss: Add support for OMAP4 camera interface - Build system

Sergio Aguirre (5):
      v4l: omap4iss: Add support for OMAP4 camera interface - Core
      v4l: omap4iss: Add support for OMAP4 camera interface - Video devices
      v4l: omap4iss: Add support for OMAP4 camera interface - CSI receivers
      v4l: omap4iss: Add support for OMAP4 camera interface - IPIPE(IF)
      v4l: omap4iss: Add support for OMAP4 camera interface - Resizer

 Documentation/video4linux/omap4_camera.txt   |   63 ++
 drivers/staging/media/Kconfig                |    2 +
 drivers/staging/media/Makefile               |    1 +
 drivers/staging/media/omap4iss/Kconfig       |   12 +
 drivers/staging/media/omap4iss/Makefile      |    6 +
 drivers/staging/media/omap4iss/TODO          |    4 +
 drivers/staging/media/omap4iss/iss.c         | 1477 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss.h         |  153 ++++
 drivers/staging/media/omap4iss/iss_csi2.c    | 1368 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_csi2.h    |  156 ++++
 drivers/staging/media/omap4iss/iss_csiphy.c  |  278 +++++++
 drivers/staging/media/omap4iss/iss_csiphy.h  |   51 ++
 drivers/staging/media/omap4iss/iss_ipipe.c   |  581 +++++++++++++
 drivers/staging/media/omap4iss/iss_ipipe.h   |   67 ++
 drivers/staging/media/omap4iss/iss_ipipeif.c |  847 +++++++++++++++++++
 drivers/staging/media/omap4iss/iss_ipipeif.h |   92 +++
 drivers/staging/media/omap4iss/iss_regs.h    |  883 ++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_resizer.c |  905 +++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_resizer.h |   75 ++
 drivers/staging/media/omap4iss/iss_video.c   | 1129 +++++++++++++++++++++++++
 drivers/staging/media/omap4iss/iss_video.h   |  201 +++++
 include/media/omap4iss.h                     |   65 ++
 22 files changed, 8416 insertions(+)
 create mode 100644 Documentation/video4linux/omap4_camera.txt
 create mode 100644 drivers/staging/media/omap4iss/Kconfig
 create mode 100644 drivers/staging/media/omap4iss/Makefile
 create mode 100644 drivers/staging/media/omap4iss/TODO
 create mode 100644 drivers/staging/media/omap4iss/iss.c
 create mode 100644 drivers/staging/media/omap4iss/iss.h
 create mode 100644 drivers/staging/media/omap4iss/iss_csi2.c
 create mode 100644 drivers/staging/media/omap4iss/iss_csi2.h
 create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.c
 create mode 100644 drivers/staging/media/omap4iss/iss_csiphy.h
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.c
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipe.h
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.c
 create mode 100644 drivers/staging/media/omap4iss/iss_ipipeif.h
 create mode 100644 drivers/staging/media/omap4iss/iss_regs.h
 create mode 100644 drivers/staging/media/omap4iss/iss_resizer.c
 create mode 100644 drivers/staging/media/omap4iss/iss_resizer.h
 create mode 100644 drivers/staging/media/omap4iss/iss_video.c
 create mode 100644 drivers/staging/media/omap4iss/iss_video.h
 create mode 100644 include/media/omap4iss.h

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR v3.13] OMAP4 ISS driver
  2013-10-15 16:13 [GIT PULL FOR v3.13] OMAP4 ISS driver Laurent Pinchart
@ 2013-10-15 16:35 ` Greg Kroah-Hartman
  2013-10-15 16:38   ` Laurent Pinchart
  2013-10-15 20:03   ` Dan Carpenter
  0 siblings, 2 replies; 6+ messages in thread
From: Greg Kroah-Hartman @ 2013-10-15 16:35 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: devel, Hans Verkuil, Sergio Aguirre, Sakari Ailus, Dan Carpenter,
	linux-media

On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote:
> Hello,
> 
> Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera 
> interface).

I don't take pull requests for staging drivers.

But even if I did, Mauro takes drivers/staging/media/ code, so it's up
to him to take this, not me.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR v3.13] OMAP4 ISS driver
  2013-10-15 16:35 ` Greg Kroah-Hartman
@ 2013-10-15 16:38   ` Laurent Pinchart
  2013-10-17 12:28     ` Mauro Carvalho Chehab
  2013-10-15 20:03   ` Dan Carpenter
  1 sibling, 1 reply; 6+ messages in thread
From: Laurent Pinchart @ 2013-10-15 16:38 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: devel, Hans Verkuil, Sergio Aguirre, Sakari Ailus, Dan Carpenter,
	linux-media

Hi Greg,

On Tuesday 15 October 2013 09:35:30 Greg Kroah-Hartman wrote:
> On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote:
> > Hello,
> > 
> > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS
> > (camera interface).
> 
> I don't take pull requests for staging drivers.
>
> But even if I did, Mauro takes drivers/staging/media/ code, so it's up to
> him to take this, not me.

My bad, I shouldn't have CC'ed you, sorry about the noise. I believe Mauro 
will handle this, as the linuxtv patchwork has picked the pull request up.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR v3.13] OMAP4 ISS driver
  2013-10-15 16:35 ` Greg Kroah-Hartman
  2013-10-15 16:38   ` Laurent Pinchart
@ 2013-10-15 20:03   ` Dan Carpenter
  2013-10-15 20:28     ` Laurent Pinchart
  1 sibling, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2013-10-15 20:03 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: Laurent Pinchart, devel, Hans Verkuil, Sergio Aguirre,
	Sakari Ailus, linux-media

On Tue, Oct 15, 2013 at 09:35:30AM -0700, Greg Kroah-Hartman wrote:
> On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote:
> > Hello,
> > 
> > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS (camera 
> > interface).
> 
> I don't take pull requests for staging drivers.
> 

Yeah...  Pull request get far less review.  I never bother reviewing
them, honestly.  I feel bad for that.

regards,
dan carpenter


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR v3.13] OMAP4 ISS driver
  2013-10-15 20:03   ` Dan Carpenter
@ 2013-10-15 20:28     ` Laurent Pinchart
  0 siblings, 0 replies; 6+ messages in thread
From: Laurent Pinchart @ 2013-10-15 20:28 UTC (permalink / raw)
  To: Dan Carpenter
  Cc: Greg Kroah-Hartman, devel, Hans Verkuil, Sergio Aguirre,
	Sakari Ailus, linux-media

Hi Dan,

On Tuesday 15 October 2013 23:03:45 Dan Carpenter wrote:
> On Tue, Oct 15, 2013 at 09:35:30AM -0700, Greg Kroah-Hartman wrote:
> > On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote:
> > > Hello,
> > > 
> > > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS
> > > (camera interface).
> > 
> > I don't take pull requests for staging drivers.
> 
> Yeah...  Pull request get far less review.  I never bother reviewing
> them, honestly.  I feel bad for that.

That's why I've posted the patches for review two weeks ago. As noted in the 
pull request, I will address all comments received (there was quite a lot of 
small interesting comments but no show-stopper) as part of the driver cleanup 
work to move it out of staging.

-- 
Regards,

Laurent Pinchart


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [GIT PULL FOR v3.13] OMAP4 ISS driver
  2013-10-15 16:38   ` Laurent Pinchart
@ 2013-10-17 12:28     ` Mauro Carvalho Chehab
  0 siblings, 0 replies; 6+ messages in thread
From: Mauro Carvalho Chehab @ 2013-10-17 12:28 UTC (permalink / raw)
  To: Laurent Pinchart
  Cc: Greg Kroah-Hartman, devel, Hans Verkuil, Sergio Aguirre,
	Sakari Ailus, Dan Carpenter, linux-media

Em Tue, 15 Oct 2013 18:38:40 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:

> Hi Greg,
> 
> On Tuesday 15 October 2013 09:35:30 Greg Kroah-Hartman wrote:
> > On Tue, Oct 15, 2013 at 06:13:04PM +0200, Laurent Pinchart wrote:
> > > Hello,
> > > 
> > > Here's a pull request for v3.13 that adds a driver for the OMAP4 ISS
> > > (camera interface).
> > 
> > I don't take pull requests for staging drivers.
> >
> > But even if I did, Mauro takes drivers/staging/media/ code, so it's up to
> > him to take this, not me.
> 
> My bad, I shouldn't have CC'ed you, sorry about the noise. I believe Mauro 
> will handle this, as the linuxtv patchwork has picked the pull request up.

Yeah, I'll handle this.

-- 

Cheers,
Mauro

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2013-10-17 12:28 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-10-15 16:13 [GIT PULL FOR v3.13] OMAP4 ISS driver Laurent Pinchart
2013-10-15 16:35 ` Greg Kroah-Hartman
2013-10-15 16:38   ` Laurent Pinchart
2013-10-17 12:28     ` Mauro Carvalho Chehab
2013-10-15 20:03   ` Dan Carpenter
2013-10-15 20:28     ` Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox