From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] v4l: vsp1: Fix struct vsp1_drm documentation
Date: Thu, 02 Mar 2017 14:08:43 +0200 [thread overview]
Message-ID: <3893724.eCjZMHPHA5@avalon> (raw)
In-Reply-To: <1488449542-28990-1-git-send-email-kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Thursday 02 Mar 2017 10:12:22 Kieran Bingham wrote:
> The struct vsp1_drm references a member 'planes' which doesn't exist.
> Correctly identify this documentation against the 'inputs'
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree, thank you.
> ---
> drivers/media/platform/vsp1/vsp1_drm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_drm.h
> b/drivers/media/platform/vsp1/vsp1_drm.h index 9e28ab9254ba..c8d2f88fc483
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_drm.h
> +++ b/drivers/media/platform/vsp1/vsp1_drm.h
> @@ -21,7 +21,7 @@
> * vsp1_drm - State for the API exposed to the DRM driver
> * @pipe: the VSP1 pipeline used for display
> * @num_inputs: number of active pipeline inputs at the beginning of an
> update - * @planes: source crop rectangle, destination compose rectangle
> and z-order + * @inputs: source crop rectangle, destination compose
> rectangle and z-order * position for every input
> */
> struct vsp1_drm {
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2017-03-02 12:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 10:12 [PATCH] v4l: vsp1: Fix struct vsp1_drm documentation Kieran Bingham
2017-03-02 12:08 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3893724.eCjZMHPHA5@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).