Re: [PATCH v2 01/21] dt-bindings: display: tegra: add Tegra20 VIP

Rob Herring
2022-12-01T23:19:41Z

On Mon, Nov 28, 2022 at 04:23:16PM +0100, Luca Ceresoli wrote:
> VIP is the parallel video capture component within the video input
> subsystem of Tegra20 (and other Tegra chips, apparently).
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
>
> ---
>
> Changed in v2 (suggested by Krzysztof Kozlowski):
> - remove redundant "bindings" from subject line
> - remove $nodename
> - add channel@0 description
> - add reg: const: 0
> ---
> .../display/tegra/nvidia,tegra20-vip.yaml | 63 +++++++++++++++++++
> MAINTAINERS | 7 +++
> 2 files changed, 70 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
> new file mode 100644
> index 000000000000..44be2e16c9b4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
> @@ -0,0 +1,63 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/tegra/nvidia,tegra20-vip.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: NVIDIA Tegra VIP (parallel video capture) controller
> +
> +maintainers:
> + - Luca Ceresoli <luca.ceresoli@bootlin.com>
> +
> +properties:
> + compatible:
> + enum:
> + - nvidia,tegra20-vip
> +
> + "#address-cells":
> + const: 1
> +
> + "#size-cells":
> + const: 0
> +
> + channel@0:

Kind of odd there is only 1 channel with a unit-address. Are more
channels coming? Please make the binding as complete as possible even if
no driver support yet.

> + description: parallel video capture interface for the VI
> + type: object
> +
> + properties:
> + reg:
> + const: 0
> +
> + ports:
> + $ref: /schemas/graph.yaml#/properties/ports
> +
> + properties:
> + port@0:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Port receiving the video stream from the sensor
> +
> + port@1:
> + $ref: /schemas/graph.yaml#/properties/port
> + description:
> + Port sending the video stream to the VI
> +
> + required:
> + - port@0
> + - port@1
> +
> + additionalProperties: false

A bit easier to read the indented cases if this is above 'properties'.

> +
> + required:
> + - reg
> + - ports
> +
> +unevaluatedProperties: false
> +
> +required:
> + - compatible
> + - "#address-cells"
> + - "#size-cells"
> + - channel@0
> +
> +# see nvidia,tegra20-vi.yaml for an example
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 69565ac0c224..92c762f85f17 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -20315,6 +20315,13 @@ S: Maintained
> F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-host1x.yaml
> F: drivers/staging/media/tegra-video/
>
> +TEGRA VIDEO DRIVER FOR TEGRA20 VIP (PARALLEL VIDEO CAPTURE)
> +M: Luca Ceresoli <luca.ceresoli@bootlin.com>
> +L: linux-media@vger.kernel.org
> +L: linux-tegra@vger.kernel.org
> +S: Maintained
> +F: Documentation/devicetree/bindings/display/tegra/nvidia,tegra20-vip.yaml
> +
> TEGRA XUSB PADCTL DRIVER
> M: JC Kuo <jckuo@nvidia.com>
> S: Supported
> --
> 2.34.1
>
>