From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00B96C4167B for ; Fri, 16 Dec 2022 16:14:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232164AbiLPQO2 (ORCPT ); Fri, 16 Dec 2022 11:14:28 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45672 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232009AbiLPQNu (ORCPT ); Fri, 16 Dec 2022 11:13:50 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CFE5012ACB for ; Fri, 16 Dec 2022 08:12:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1671207157; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zFkMxUWLdwGHIAixRcJsjatehdV3JvWTV1e5ITjujjY=; b=cFJ5S5kZT6YYxMoNYCmYQ3EHHRz9mHOWUi0zSxWMTKGuFCbrX4SBxG0YKgueSlfjLVQ1lk N+82Rvf/qCwWGC1D3AjAKxzK5ORxeAFqwqKtilWEz1GSLYjTSWgdnNyyVpJTsFJGykWTWz Q5XfMPaM46wFBA0EdU0nmoPa5jZWJd8= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-516-q8M5Mbo_OIuTuKIfpus-Fg-1; Fri, 16 Dec 2022 11:12:35 -0500 X-MC-Unique: q8M5Mbo_OIuTuKIfpus-Fg-1 Received: by mail-ej1-f72.google.com with SMTP id nb4-20020a1709071c8400b007c18ba778e9so2124881ejc.16 for ; Fri, 16 Dec 2022 08:12:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zFkMxUWLdwGHIAixRcJsjatehdV3JvWTV1e5ITjujjY=; b=M+Dg2VVvfv5cNi08F+VNaXfVk3Y9r4T3dquWT6zo+6WfCUSy6M0k419+JkfuALtxt2 fMbDHDQYT31aWE9nWN3N5w4fXB8z+2BSf8FtQUeuBG9tqIlYQmSsks4iHS/vLIQ+eQu3 W6aJGYoENHdDljuZG2YZWG8Ud2ax0LgnJRa4zFYSxLzrKlUezkBSFC2LH79NubJB+9Xm pEboGSbX4oJRscpJCbRpYk8xjn5s1+3zv0TvoDJYU5sSj19iaz71tTXvqsUfNMK56xvh BB1MOomx8aUZyt807mltnhTnhMCcFI0TIIUqaN79Eb9ZlW5307wkjn+hNe7hMRCTZDsC +E5A== X-Gm-Message-State: AFqh2kqIh7bkBe5trxIhlWyD44OZXFQ+k2tI5M/3yocTf4yLaVeCXrnQ i1gKGsVbGxxbcbRPTVkmHnSenoMBBq/9itRFAulhLG92M1uo/Qn78q3C2wKjXvVXJerkPpkxQYx IwTkuTEWnlRwIbyfh6Pknj5U= X-Received: by 2002:a17:906:1f4d:b0:7e0:eed0:8beb with SMTP id d13-20020a1709061f4d00b007e0eed08bebmr2658445ejk.41.1671207154443; Fri, 16 Dec 2022 08:12:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXuGHAW3XAtvRofwJ5XrWPr4dqsyehv9s53hIQDwCoVun5ID0UVhjYDByv0SmlRBlovLVvwUjw== X-Received: by 2002:a17:906:1f4d:b0:7e0:eed0:8beb with SMTP id d13-20020a1709061f4d00b007e0eed08bebmr2658424ejk.41.1671207154296; Fri, 16 Dec 2022 08:12:34 -0800 (PST) Received: from ?IPV6:2001:1c00:2a07:3a01:67e5:daf9:cec0:df6? (2001-1c00-2a07-3a01-67e5-daf9-cec0-0df6.cable.dynamic.v6.ziggo.nl. [2001:1c00:2a07:3a01:67e5:daf9:cec0:df6]) by smtp.gmail.com with ESMTPSA id g17-20020a17090604d100b007c0e23b5615sm997680eja.34.2022.12.16.08.12.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 16 Dec 2022 08:12:33 -0800 (PST) Message-ID: <38ee7caa-d028-9cc4-7e13-e3642a0bcf77@redhat.com> Date: Fri, 16 Dec 2022 17:12:32 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v3 05/11] leds: led-class: Add generic [devm_]led_get() Content-Language: en-US To: Andy Shevchenko Cc: Mark Gross , Pavel Machek , Lee Jones , Linus Walleij , Daniel Scally , Laurent Pinchart , Mauro Carvalho Chehab , Sakari Ailus , platform-driver-x86@vger.kernel.org, linux-leds@vger.kernel.org, linux-gpio@vger.kernel.org, Kate Hsuan , Mark Pearson , Andy Yeh , Yao Hao , linux-media@vger.kernel.org References: <20221216113013.126881-1-hdegoede@redhat.com> <20221216113013.126881-6-hdegoede@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi, On 12/16/22 17:07, Andy Shevchenko wrote: > On Fri, Dec 16, 2022 at 04:54:59PM +0100, Hans de Goede wrote: >> On 12/16/22 14:43, Andy Shevchenko wrote: >>> On Fri, Dec 16, 2022 at 12:30:07PM +0100, Hans de Goede wrote: > > ... > >>>> +EXPORT_SYMBOL_GPL(led_add_lookup); >>> >>>> +EXPORT_SYMBOL_GPL(led_remove_lookup); >>> >>> Wondering why we can't make at least those two to be namespaced from day 1, >> >> switching the LED subsystem code to use module namespaces is >> a RFE which is independent of / orthogonal to this patchset. > > Adding new unnamespaced APIs only delays and increases a burden of the work. > We can start already for the logically separated subset of API, no? That's why > I asked about this. Sorry, but I really see this as an independent changes and there is enough discussion around these changes as is without throwing this into the mix. Regards, Hans