From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl
Subject: Re: [PATCH v3 1/4] v4l: libv4lsubdev: Make mbus_formats array const
Date: Mon, 25 Jan 2016 22:17:46 +0200 [thread overview]
Message-ID: <3931467.gMsOrk7hPF@avalon> (raw)
In-Reply-To: <1453725585-4165-2-git-send-email-sakari.ailus@linux.intel.com>
Hi Sakari,
Thank you for the patch.
On Monday 25 January 2016 14:39:42 Sakari Ailus wrote:
> The array is already static and may not be modified at runtime. Make it
> const.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> utils/media-ctl/libv4l2subdev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/media-ctl/libv4l2subdev.c
> b/utils/media-ctl/libv4l2subdev.c index dc2cd87..e45834f 100644
> --- a/utils/media-ctl/libv4l2subdev.c
> +++ b/utils/media-ctl/libv4l2subdev.c
> @@ -715,7 +715,7 @@ int v4l2_subdev_parse_setup_formats(struct media_device
> *media, const char *p) return *end ? -EINVAL : 0;
> }
>
> -static struct {
> +static const struct {
> const char *name;
> enum v4l2_mbus_pixelcode code;
> } mbus_formats[] = {
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2016-01-25 20:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-25 12:39 [PATCH v3 0/4] List supported formats in libv4l2subdev Sakari Ailus
2016-01-25 12:39 ` [PATCH v3 1/4] v4l: libv4lsubdev: Make mbus_formats array const Sakari Ailus
2016-01-25 20:17 ` Laurent Pinchart [this message]
2016-01-25 12:39 ` [PATCH v3 2/4] libv4l2subdev: Use generated format definitions in libv4l2subdev Sakari Ailus
2016-02-15 14:39 ` Laurent Pinchart
2016-01-25 12:39 ` [PATCH v3 3/4] libv4l2subdev: Add a function to list library supported pixel codes Sakari Ailus
2016-02-15 14:43 ` Laurent Pinchart
2016-02-15 15:31 ` Sakari Ailus
2016-01-25 12:39 ` [PATCH v3 4/4] media-ctl: List supported media bus formats Sakari Ailus
2016-02-15 14:44 ` Laurent Pinchart
2016-02-15 15:32 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3931467.gMsOrk7hPF@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox