* [PATCH 1/1] smiapp: Remove useless rval assignment in smiapp_get_pdata()
@ 2015-04-10 22:42 Sakari Ailus
2015-11-09 14:58 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Sakari Ailus @ 2015-04-10 22:42 UTC (permalink / raw)
To: linux-media
The value is not used after the assignment.
Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
---
drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c
index 636ebd6..4b1e112 100644
--- a/drivers/media/i2c/smiapp/smiapp-core.c
+++ b/drivers/media/i2c/smiapp/smiapp-core.c
@@ -3032,10 +3032,8 @@ static struct smiapp_platform_data *smiapp_get_pdata(struct device *dev)
pdata->op_sys_clock = devm_kcalloc(
dev, bus_cfg->nr_of_link_frequencies + 1 /* guardian */,
sizeof(*pdata->op_sys_clock), GFP_KERNEL);
- if (!pdata->op_sys_clock) {
- rval = -ENOMEM;
+ if (!pdata->op_sys_clock)
goto out_err;
- }
for (i = 0; i < bus_cfg->nr_of_link_frequencies; i++) {
pdata->op_sys_clock[i] = bus_cfg->link_frequencies[i];
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/1] smiapp: Remove useless rval assignment in smiapp_get_pdata()
2015-04-10 22:42 [PATCH 1/1] smiapp: Remove useless rval assignment in smiapp_get_pdata() Sakari Ailus
@ 2015-11-09 14:58 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2015-11-09 14:58 UTC (permalink / raw)
To: Sakari Ailus; +Cc: linux-media
Hi Sakari,
Thank you for the patch.
On Saturday 11 April 2015 01:42:47 Sakari Ailus wrote:
> The value is not used after the assignment.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
> b/drivers/media/i2c/smiapp/smiapp-core.c index 636ebd6..4b1e112 100644
> --- a/drivers/media/i2c/smiapp/smiapp-core.c
> +++ b/drivers/media/i2c/smiapp/smiapp-core.c
> @@ -3032,10 +3032,8 @@ static struct smiapp_platform_data
> *smiapp_get_pdata(struct device *dev) pdata->op_sys_clock = devm_kcalloc(
> dev, bus_cfg->nr_of_link_frequencies + 1 /* guardian */,
> sizeof(*pdata->op_sys_clock), GFP_KERNEL);
> - if (!pdata->op_sys_clock) {
> - rval = -ENOMEM;
> + if (!pdata->op_sys_clock)
> goto out_err;
> - }
>
> for (i = 0; i < bus_cfg->nr_of_link_frequencies; i++) {
> pdata->op_sys_clock[i] = bus_cfg->link_frequencies[i];
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-11-09 14:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-04-10 22:42 [PATCH 1/1] smiapp: Remove useless rval assignment in smiapp_get_pdata() Sakari Ailus
2015-11-09 14:58 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).