From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, sylwester.nawrocki@gmail.com,
a.hajda@samsung.com
Subject: Re: [PATCH v2.2 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT
Date: Thu, 31 Oct 2013 15:45:54 +0100 [thread overview]
Message-ID: <3977240.SUD62DEGqA@avalon> (raw)
In-Reply-To: <1381873617-5481-1-git-send-email-sakari.ailus@iki.fi>
Hi Sakari,
Thank you for the patch.
On Wednesday 16 October 2013 00:46:57 Sakari Ailus wrote:
> Pads that set this flag must be connected by an active link for the entity
> to stream.
>
> Signed-off-by: Sakari Ailus <sakari.ailus@iki.fi>
> Acked-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> Documentation/DocBook/media/v4l/media-ioc-enum-links.xml | 9 +++++++++
> include/uapi/linux/media.h | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml index
> 355df43..cf85485 100644
> --- a/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> +++ b/Documentation/DocBook/media/v4l/media-ioc-enum-links.xml
> @@ -134,6 +134,15 @@
> <entry>Output pad, relative to the entity. Output pads source data
> and are origins of links.</entry>
> </row>
> + <row>
> + <entry><constant>MEDIA_PAD_FL_MUST_CONNECT</constant></entry>
> + <entry>If this flag is set and the pad is linked to any other
> + pad, then at least one of those links must be enabled for the
> + entity to be able to stream. There could be temporary reasons
> + (e.g. device configuration dependent) for the pad to need
> + enabled links even when this flag isn't set; the absence of the
> + flag doesn't imply there is none.</entry>
> + </row>
> </tbody>
> </tgroup>
> </table>
> diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h
> index ed49574..d847c76 100644
> --- a/include/uapi/linux/media.h
> +++ b/include/uapi/linux/media.h
> @@ -98,6 +98,7 @@ struct media_entity_desc {
>
> #define MEDIA_PAD_FL_SINK (1 << 0)
> #define MEDIA_PAD_FL_SOURCE (1 << 1)
> +#define MEDIA_PAD_FL_MUST_CONNECT (1 << 2)
>
> struct media_pad_desc {
> __u32 entity; /* entity ID */
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-10-31 14:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 23:17 [PATCH v2 0/4] Add MEDIA_PAD_FL_MUST_CONNECT pad flag, check it Sakari Ailus
2013-10-02 23:17 ` [PATCH v2 1/4] media: Add pad flag MEDIA_PAD_FL_MUST_CONNECT Sakari Ailus
2013-10-02 23:29 ` Laurent Pinchart
2013-10-03 2:16 ` Sylwester Nawrocki
2013-10-03 8:43 ` Sakari Ailus
2013-10-03 9:40 ` Laurent Pinchart
2013-10-03 22:13 ` Sylwester Nawrocki
2013-10-13 10:58 ` [PATCH v2.1 " Sakari Ailus
2013-10-13 11:03 ` Sakari Ailus
2013-10-15 15:22 ` Laurent Pinchart
2013-10-15 21:41 ` Sakari Ailus
2013-10-15 21:46 ` [PATCH v2.2 " Sakari Ailus
2013-10-31 14:45 ` Laurent Pinchart [this message]
2013-10-13 11:00 ` [PATCH v2.1 2/4] media: Check for active links on pads with MEDIA_PAD_FL_MUST_CONNECT flag Sakari Ailus
2013-10-02 23:17 ` [PATCH v2 " Sakari Ailus
2013-10-15 21:48 ` [PATCH v2.2 " Sakari Ailus
2013-10-31 14:46 ` Laurent Pinchart
2013-10-02 23:17 ` [PATCH v2 3/4] omap3isp: Mark which pads must connect Sakari Ailus
2013-10-02 23:17 ` [PATCH v2 4/4] omap3isp: Add resizer data rate configuration to resizer_link_validate Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3977240.SUD62DEGqA@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
--cc=sylwester.nawrocki@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).