Re: [PATCH 06/24] staging: media: atmel-sama5d2-isc: Convert to platform remove callback returning void

Nicolas Ferre
2023-04-03T16:24:57Z

On 03/04/2023 at 17:39, Uwe Kleine-König wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Thanks. Best regards,
Nicolas

> ---
> drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> index ba0614f981a2..cc744cea1d0e 100644
> --- a/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> +++ b/drivers/staging/media/deprecated/atmel/atmel-sama5d2-isc.c
> @@ -580,7 +580,7 @@ static int atmel_isc_probe(struct platform_device *pdev)
> return ret;
> }
>
> -static int atmel_isc_remove(struct platform_device *pdev)
> +static void atmel_isc_remove(struct platform_device *pdev)
> {
> struct isc_device *isc = platform_get_drvdata(pdev);
>
> @@ -594,8 +594,6 @@ static int atmel_isc_remove(struct platform_device *pdev)
> clk_disable_unprepare(isc->hclock);
>
> atmel_isc_clk_cleanup(isc);
> -
> - return 0;
> }
>
> static int __maybe_unused isc_runtime_suspend(struct device *dev)
> @@ -638,7 +636,7 @@ MODULE_DEVICE_TABLE(of, atmel_isc_of_match);
>
> static struct platform_driver atmel_isc_driver = {
> .probe = atmel_isc_probe,
> - .remove = atmel_isc_remove,
> + .remove_new = atmel_isc_remove,
> .driver = {
> .name = "atmel-sama5d2-isc",
> .pm = &atmel_isc_dev_pm_ops,
> --
> 2.39.2
>

--
Nicolas Ferre