Re: [PATCH] [media] cec: GIVE_PHYSICAL_ADDR should respond to unregistered device

[Jose Abreu <Jose.Abreu@synopsys.com>]

On 14-09-2017 16:09, Hans Verkuil wrote:
> On 09/14/17 15:28, Jose Abreu wrote:
>
>> Actually, I have at least one more fix which I don't know if it's
>> valid and I didn't manage to actually write it in a nice way.
>> This one is for CEC 2.0. My test equipment (which is certified)
>> in some tests sends msgs only with the opcode. As the received
>> msg length does not match the expected one CEC core is rejecting
>> the message and my compliance test is failling (test is 4.2.3).
> In the HDMI 1.4 spec in CEC 7.3 (Frame Validation) it says that a follower
> should ignore frames that are too small.
>
> At the same time unsupported opcodes should result in a Feature Abort.
>
> If you don't send a properly formed message, then it's not clear to me
> what should happen. Which opcode failed?

Hmm, yeah, the spec confirms. The failing opcodes are the ones
that have arguments, the test equipment is just sending the
header plus opcode. Anyway, for this failing test the MOI for
this equipment is not approved so I will probably carry this fix
only locally and send it upstream only if the MOI gets approved.

>
>> Have you run this test? Did it pass?
> No, we haven't. Never got around to that.

Ok. I can say that CEC 1.4 + CEC 2.0 all pass compliance with
this patch and with my local fix + my test app!

Best regards,
Jose Miguel Abreu

>
> Regards,
>
> 	Hans
>
>> Best regards,
>> Jose Miguel Abreu
>>
>>> Regards,
>>>
>>> 	Hans