* [PATCH] media: adv7180: Add of compatible strings for full family
@ 2016-02-23 11:58 Julian Scheel
2016-02-23 20:06 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Julian Scheel @ 2016-02-23 11:58 UTC (permalink / raw)
To: linux-media, lars, hverkuil; +Cc: Julian Scheel
Add entries for all supported chip variants into the of_match list, so that
the matching driver_info can be selected when using dt.
Change-Id: I6ff849726c8f475c81e848423b27c35f2ccb0509
Signed-off-by: Julian Scheel <julian@jusst.de>
---
drivers/media/i2c/adv7180.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
index ff57c1d..5515f3d 100644
--- a/drivers/media/i2c/adv7180.c
+++ b/drivers/media/i2c/adv7180.c
@@ -1328,6 +1328,14 @@ static SIMPLE_DEV_PM_OPS(adv7180_pm_ops, adv7180_suspend, adv7180_resume);
#ifdef CONFIG_OF
static const struct of_device_id adv7180_of_id[] = {
{ .compatible = "adi,adv7180", },
+ { .compatible = "adi,adv7182", },
+ { .compatible = "adi,adv7280", },
+ { .compatible = "adi,adv7280-m", },
+ { .compatible = "adi,adv7281", },
+ { .compatible = "adi,adv7281-m", },
+ { .compatible = "adi,adv7281-ma", },
+ { .compatible = "adi,adv7282", },
+ { .compatible = "adi,adv7282-m", },
{ },
};
--
2.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] media: adv7180: Add of compatible strings for full family
2016-02-23 11:58 [PATCH] media: adv7180: Add of compatible strings for full family Julian Scheel
@ 2016-02-23 20:06 ` Laurent Pinchart
2016-02-23 20:12 ` Julian Scheel
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2016-02-23 20:06 UTC (permalink / raw)
To: Julian Scheel; +Cc: linux-media, lars, hverkuil
Hi Julian,
Thank you for the patch.
On Tuesday 23 February 2016 12:58:19 Julian Scheel wrote:
> Add entries for all supported chip variants into the of_match list, so that
> the matching driver_info can be selected when using dt.
How about starting by adding a DT bindings document ?
> Change-Id: I6ff849726c8f475c81e848423b27c35f2ccb0509
I sympathize with you for the pain gerrit is inflicting on you, but don't
share it with all upstream developers please, you can remove this :-)
> Signed-off-by: Julian Scheel <julian@jusst.de>
> ---
> drivers/media/i2c/adv7180.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> index ff57c1d..5515f3d 100644
> --- a/drivers/media/i2c/adv7180.c
> +++ b/drivers/media/i2c/adv7180.c
> @@ -1328,6 +1328,14 @@ static SIMPLE_DEV_PM_OPS(adv7180_pm_ops,
> adv7180_suspend, adv7180_resume); #ifdef CONFIG_OF
> static const struct of_device_id adv7180_of_id[] = {
> { .compatible = "adi,adv7180", },
> + { .compatible = "adi,adv7182", },
> + { .compatible = "adi,adv7280", },
> + { .compatible = "adi,adv7280-m", },
> + { .compatible = "adi,adv7281", },
> + { .compatible = "adi,adv7281-m", },
> + { .compatible = "adi,adv7281-ma", },
> + { .compatible = "adi,adv7282", },
> + { .compatible = "adi,adv7282-m", },
> { },
> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: adv7180: Add of compatible strings for full family
2016-02-23 20:06 ` Laurent Pinchart
@ 2016-02-23 20:12 ` Julian Scheel
2016-02-23 20:27 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Julian Scheel @ 2016-02-23 20:12 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: linux-media, lars, hverkuil
Hi Laurent,
thanks for the fast review :)
On 23.02.16 21:06, Laurent Pinchart wrote:
> On Tuesday 23 February 2016 12:58:19 Julian Scheel wrote:
>> Add entries for all supported chip variants into the of_match list, so that
>> the matching driver_info can be selected when using dt.
>
> How about starting by adding a DT bindings document ?
Probably a good thing to do. Didn't think about it as the of_match table
was already there. Are you ok with the document being added within this
commit or shall I better split it?
>> Change-Id: I6ff849726c8f475c81e848423b27c35f2ccb0509
>
> I sympathize with you for the pain gerrit is inflicting on you, but don't
> share it with all upstream developers please, you can remove this :-)
Hah, so true. Will drop it in v2 :)
>> Signed-off-by: Julian Scheel <julian@jusst.de>
>> ---
>> drivers/media/i2c/adv7180.c | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
>> index ff57c1d..5515f3d 100644
>> --- a/drivers/media/i2c/adv7180.c
>> +++ b/drivers/media/i2c/adv7180.c
>> @@ -1328,6 +1328,14 @@ static SIMPLE_DEV_PM_OPS(adv7180_pm_ops,
>> adv7180_suspend, adv7180_resume); #ifdef CONFIG_OF
>> static const struct of_device_id adv7180_of_id[] = {
>> { .compatible = "adi,adv7180", },
>> + { .compatible = "adi,adv7182", },
>> + { .compatible = "adi,adv7280", },
>> + { .compatible = "adi,adv7280-m", },
>> + { .compatible = "adi,adv7281", },
>> + { .compatible = "adi,adv7281-m", },
>> + { .compatible = "adi,adv7281-ma", },
>> + { .compatible = "adi,adv7282", },
>> + { .compatible = "adi,adv7282-m", },
>> { },
>> };
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] media: adv7180: Add of compatible strings for full family
2016-02-23 20:12 ` Julian Scheel
@ 2016-02-23 20:27 ` Laurent Pinchart
0 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2016-02-23 20:27 UTC (permalink / raw)
To: Julian Scheel; +Cc: linux-media, lars, hverkuil
Hi Julian,
On Tuesday 23 February 2016 21:12:13 Julian Scheel wrote:
> Hi Laurent,
>
> thanks for the fast review :)
>
> On 23.02.16 21:06, Laurent Pinchart wrote:
> > On Tuesday 23 February 2016 12:58:19 Julian Scheel wrote:
> >> Add entries for all supported chip variants into the of_match list, so
> >> that the matching driver_info can be selected when using dt.
> >
> > How about starting by adding a DT bindings document ?
>
> Probably a good thing to do. Didn't think about it as the of_match table
> was already there. Are you ok with the document being added within this
> commit or shall I better split it?
A separate patch would be nice if you don't mind.
> >> Change-Id: I6ff849726c8f475c81e848423b27c35f2ccb0509
> >
> > I sympathize with you for the pain gerrit is inflicting on you, but don't
> > share it with all upstream developers please, you can remove this :-)
>
> Hah, so true. Will drop it in v2 :)
Thanks.
> >> Signed-off-by: Julian Scheel <julian@jusst.de>
> >> ---
> >>
> >> drivers/media/i2c/adv7180.c | 8 ++++++++
> >> 1 file changed, 8 insertions(+)
> >>
> >> diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c
> >> index ff57c1d..5515f3d 100644
> >> --- a/drivers/media/i2c/adv7180.c
> >> +++ b/drivers/media/i2c/adv7180.c
> >> @@ -1328,6 +1328,14 @@ static SIMPLE_DEV_PM_OPS(adv7180_pm_ops,
> >> adv7180_suspend, adv7180_resume);
> >> #ifdef CONFIG_OF
> >> static const struct of_device_id adv7180_of_id[] = {
> >> { .compatible = "adi,adv7180", },
> >> + { .compatible = "adi,adv7182", },
> >> + { .compatible = "adi,adv7280", },
> >> + { .compatible = "adi,adv7280-m", },
> >> + { .compatible = "adi,adv7281", },
> >> + { .compatible = "adi,adv7281-m", },
> >> + { .compatible = "adi,adv7281-ma", },
> >> + { .compatible = "adi,adv7282", },
> >> + { .compatible = "adi,adv7282-m", },
> >> { },
> >> };
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-02-23 20:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-23 11:58 [PATCH] media: adv7180: Add of compatible strings for full family Julian Scheel
2016-02-23 20:06 ` Laurent Pinchart
2016-02-23 20:12 ` Julian Scheel
2016-02-23 20:27 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox