Re: [PATCH] rcar-vin: use monotonic timestamps

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

On Thursday 07 May 2015 08:32:51 Hans Verkuil wrote:
> On 05/07/2015 08:26 AM, Hans Verkuil wrote:
> > Even though the rcar-vin driver tells userspace that it will give a
> > monotonic timestamp, it is actually using gettimeofday. Replace this with
> > a proper monotonic timestamp.
> 
> It was clearly too early in the day for me, but here is my Signed-off-by:
> 
> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>

And my

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> > diff --git a/drivers/media/platform/soc_camera/rcar_vin.c
> > b/drivers/media/platform/soc_camera/rcar_vin.c index 35deed8..b64dfea
> > 100644
> > --- a/drivers/media/platform/soc_camera/rcar_vin.c
> > +++ b/drivers/media/platform/soc_camera/rcar_vin.c
> > @@ -894,7 +894,7 @@ static irqreturn_t rcar_vin_irq(int irq, void *data)
> > 
> >  		priv->queue_buf[slot]->v4l2_buf.field = priv->field;
> >  		priv->queue_buf[slot]->v4l2_buf.sequence = priv->sequence++;
> > 
> > -		do_gettimeofday(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> > +		v4l2_get_timestamp(&priv->queue_buf[slot]->v4l2_buf.timestamp);
> > 
> >  		vb2_buffer_done(priv->queue_buf[slot], VB2_BUF_STATE_DONE);
> >  		priv->queue_buf[slot] = NULL;

-- 
Regards,

Laurent Pinchart